-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vpcv2): add BYOIP for IPv6 functionality #32397
Conversation
idk how that one got there lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
…to vpcv2-byoip
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32397 +/- ##
=======================================
Coverage 78.66% 78.66%
=======================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
=======================================
Hits 5693 5693
Misses 1358 1358
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…to vpcv2-byoip
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
closing in favour of #32927 |
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
This change surfaces aspects of the IPv6-related fields of the VPC L1. In doing so, customers are able to make use of BYOIP for IPv6.
Description of changes
Added additional props for IPv6 pool and IPv6 CIDR blocks, as well as updated the README to contain information on bringing your own IP address to AWS and implementing it in CDK.
Description of how you validated changes
Included unit tests with the fields being used. Unfortunately, due to validation from EC2 on IPv6 addresses, it is difficult to set up a proper and sustainable integration test. Nevertheless, an integration test has been included using a provided IPv6 address.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license