Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vpcv2): add BYOIP for IPv6 functionality #32397

Closed
wants to merge 14 commits into from

Conversation

Leo10Gama
Copy link
Member

@Leo10Gama Leo10Gama commented Dec 5, 2024

Reason for this change

This change surfaces aspects of the IPv6-related fields of the VPC L1. In doing so, customers are able to make use of BYOIP for IPv6.

Description of changes

Added additional props for IPv6 pool and IPv6 CIDR blocks, as well as updated the README to contain information on bringing your own IP address to AWS and implementing it in CDK.

Description of how you validated changes

Included unit tests with the fields being used. Unfortunately, due to validation from EC2 on IPv6 addresses, it is difficult to set up a proper and sustainable integration test. Nevertheless, an integration test has been included using a provided IPv6 address.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Dec 5, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 5, 2024 23:05
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 5, 2024
idk how that one got there lmao
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (ca01a25) to head (bdb447c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32397   +/-   ##
=======================================
  Coverage   78.66%   78.66%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5693     5693           
  Misses       1358     1358           
  Partials      186      186           
Flag Coverage Δ
suite.unit 78.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.66% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: bea61a9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@shikha372
Copy link
Contributor

closing in favour of #32927

@shikha372 shikha372 closed this Jan 15, 2025
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants