chore(cli): remove unreachable v1 compat in stack selection

[mrgrain]

Reason for this change

Removing dead code. The version number of the CLI is never < 2 in release and thus this code cannot be reached.
This allowed to remove the env variable hack that enabled test scenarios to use v2 behavior.

Description of changes

Remove the unreachable if statement and then optimize code.
Also includes some minor reformatting of method parameters.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Test pipeline.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (c4136bd) to head (def6da1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32620      +/-   ##
==========================================
+ Coverage   80.49%   80.52%   +0.03%     
==========================================
  Files         106      106              
  Lines        6957     6948       -9     
  Branches     1289     1287       -2     
==========================================
- Hits         5600     5595       -5     
+ Misses       1178     1175       -3     
+ Partials      179      178       -1     

Flag	Coverage Δ
suite.unit	80.52% <100.00%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	80.52% <100.00%> (+0.03%)	⬆️

[mrgrain]

Added pr-linter/cli-integ-tested. Passed most testst except one that's currently failing on main as well 🤔

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: def6da1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.