Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert "chore: bump jsii-rosetta to 5.7 and bump other jsii tools" #32625

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Dec 21, 2024

Reverts #32603

The original PR fails the following integration test for some reason:

cdk migrate csharp deploys successfully
    ValidationError: Stack name cannot exceed 128 characters

@mrgrain mrgrain requested a review from a team as a code owner December 21, 2024 09:12
@github-actions github-actions bot added the p2 label Dec 21, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 21, 2024 09:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 21, 2024
@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Dec 21, 2024
@mrgrain
Copy link
Contributor Author

mrgrain commented Dec 21, 2024

Submitted to the test-pipeline to confirm this is unbreaking the tests.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.49%. Comparing base (ff57cc3) to head (64d7268).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32625   +/-   ##
=======================================
  Coverage   80.49%   80.49%           
=======================================
  Files         106      106           
  Lines        6957     6957           
  Branches     1289     1289           
=======================================
  Hits         5600     5600           
  Misses       1178     1178           
  Partials      179      179           
Flag Coverage Δ
suite.unit 80.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.49% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 64d7268
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 21, 2024
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Dec 21, 2024
@mrgrain
Copy link
Contributor Author

mrgrain commented Dec 21, 2024

Test pipeline has run successfully with this revert.

Copy link
Contributor

mergify bot commented Dec 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c4136bd into main Dec 21, 2024
42 checks passed
@mergify mergify bot deleted the revert-32603-mrgrain/chore/jsii-rosetta-5.7 branch December 21, 2024 14:19
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants