-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): enable additional metadata collection (under feature flag) #32827
base: main
Are you sure you want to change the base?
Conversation
Temporarily change the target branch to Note that adding import statements and |
ae763b0
to
f9f14d4
Compare
@@ -0,0 +1,96 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not see the metadata resource in this template, although you enabled the ENABLE_ADDITIONAL_METADATA_COLLECTION
FF. Is this expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is expected as all of our integration test have analyticsReporting: false
to avoid contaminate the actual DB. I enabled to flag to make sure that it does deploy on my local test machine by overriding analyticsReporting
to true
.
nested: { foo: '*' }, | ||
arr: ['*', '*', '*'], | ||
str: '*', | ||
arrOfObjects: [{ foo: { hello: '*' } }, { myFunc: '*' }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a TODO here to change this test case with your change to only collect data for our types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Verified that this build successfully. Going to ask Core team for a review and set the target branch to feature branch to merge in the change (instead of merging to main). |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #.
Reason for this change
Expand the scope of usage data collected by the AWS CDK to better inform CDK development and improve communication for security concerns and emerging issues. Currently, for those that opt in, the CDK collects usage data on your CDK version and which L2 constructs you use. For more information on current CDK behavior, see Version Reporting.
This proposal expands the scope of usage data collection to include the following from L2 constructs in CDK applications:
Description of changes
Update CDK synthesis code to additionally handle resource metadata.
On feature flag set to true, synthesis will not only inject Metadata usage like version and construct name, it will additionally look for any construct/method/feature flag metadata injected during resource creation.
Note that this PR is only part one so we will have follow up PRs to add metadata injection during resource creation.
On feature flag set to false, it should be the same as before.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
New unit tests added.
New integration tests added.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license