feat(dynamodb): add pointintimerecoveryspecification and deprecate old #32857

LeeroyHannigan · 2025-01-11T18:50:11Z

…intintimerecovery

Issue # (if applicable)

Closes #32786

Reason for this change

New feature of DynamoDB

Description of changes

Added pointInTimeRecoverySpecification which takes pointInTimeRecoveryEnabled and recoveryPeriodInDays.

Deprecated pointInTimeRecovery as it could not take recoveryPeriodInDays

Describe any new or updated permissions being added

<!— What new or updated IAM permissions are needed to support the changes being introduced ? -->

Description of how you validated changes

Integ and Unit tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…intintimerecovery

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

codecov · 2025-01-12T14:32:22Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.38%. Comparing base (9317203) to head (3b389c4).
Report is 113 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32857   +/-   ##
=======================================
  Coverage   81.38%   81.38%           
=======================================
  Files         222      222           
  Lines       13695    13695           
  Branches     2412     2412           
=======================================
  Hits        11145    11145           
  Misses       2271     2271           
  Partials      279      279

Flag	Coverage Δ
suite.unit	`81.38% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`80.69% <ø> (ø)`
packages/aws-cdk-lib/core	`82.09% <ø> (ø)`

aws-cdk-automation · 2025-01-12T15:33:26Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 3b389c4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

GavinZZ

Looks good, just some minor changes and I'm happy to approve once fixed.

GavinZZ · 2025-01-16T21:52:27Z

packages/aws-cdk-lib/aws-dynamodb/lib/table-v2.ts

+   *
+   * @default - point in time recovery is not enabled.
+   */
+  readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification | undefined;


Suggested change

readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification | undefined;

readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification;

GavinZZ · 2025-01-16T22:04:04Z

packages/aws-cdk-lib/aws-dynamodb/lib/table-v2.ts

+    const pointInTimeRecovery = props.pointInTimeRecovery ?? this.tableOptions.pointInTimeRecovery;
+
+    const pointInTimeRecoverySpecification: PointInTimeRecoverySpecification | undefined =
+      props.pointInTimeRecoverySpecification ??
+      this.tableOptions.pointInTimeRecoverySpecification ??
+      (pointInTimeRecovery !== undefined
+        ? { pointInTimeRecoveryEnabled: pointInTimeRecovery }
+        : undefined);
+


I'd prefer to check if both properties are used and throw an error instead of silently having one taking precedence over another.

Ah that's what I had initially. I'll put it back in. Thanks for taking the time to review.

GavinZZ · 2025-01-16T22:04:23Z

packages/aws-cdk-lib/aws-dynamodb/lib/table.ts

+   *
+   * @default - point in time recovery is not enabled.
+   */
+  readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification | undefined;


Suggested change

readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification | undefined;

readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification;

GavinZZ · 2025-01-16T22:04:33Z

packages/aws-cdk-lib/aws-dynamodb/lib/table.ts

@@ -1180,6 +1190,12 @@ export class Table extends TableBase {

    const { sseSpecification, encryptionKey } = this.parseEncryption(props);

+    const pointInTimeRecoverySpecification: PointInTimeRecoverySpecification | undefined =


same as above comment.

aws-cdk-automation · 2025-01-17T00:12:01Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-01-18T00:11:57Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-01-19T00:13:37Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

aws-cdk-automation · 2025-01-20T00:12:37Z

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

LeeroyHannigan · 2025-01-22T13:42:01Z

Moved to #33059

github-actions · 2025-01-22T13:42:18Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(dynamodb): add pointintimerecoveryspecification and deprecate po…

d2d304c

…intintimerecovery

github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Jan 11, 2025

aws-cdk-automation requested a review from a team January 11, 2025 18:50

aws-cdk-automation previously requested changes Jan 11, 2025

View reviewed changes

Adding pitr-specfication details to README

711b196

Adding default docstring for pointInTimeRecovery

2ccf740

Missing comma in README

3b389c4

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 12, 2025

GavinZZ requested changes Jan 16, 2025

View reviewed changes

rrhodes mentioned this pull request Jan 18, 2025

feat(dynamodb): recovery period in days for dynamodb table v1 #33010

Closed

1 task

GavinZZ added the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Jan 21, 2025

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 21, 2025

LeeroyHannigan closed this Jan 22, 2025

github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dynamodb): add pointintimerecoveryspecification and deprecate old #32857

feat(dynamodb): add pointintimerecoveryspecification and deprecate old #32857

LeeroyHannigan commented Jan 11, 2025

aws-cdk-automation left a comment

codecov bot commented Jan 12, 2025 •

edited

Loading

aws-cdk-automation commented Jan 12, 2025

GavinZZ left a comment

GavinZZ Jan 16, 2025

GavinZZ Jan 16, 2025

LeeroyHannigan Jan 16, 2025

GavinZZ Jan 16, 2025

GavinZZ Jan 16, 2025

aws-cdk-automation commented Jan 17, 2025

aws-cdk-automation commented Jan 18, 2025

aws-cdk-automation commented Jan 19, 2025

aws-cdk-automation commented Jan 20, 2025

LeeroyHannigan commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

	readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification \| undefined;
	readonly pointInTimeRecoverySpecification?: PointInTimeRecoverySpecification;

		@@ -1180,6 +1190,12 @@ export class Table extends TableBase {

		const { sseSpecification, encryptionKey } = this.parseEncryption(props);

		const pointInTimeRecoverySpecification: PointInTimeRecoverySpecification \| undefined =

feat(dynamodb): add pointintimerecoveryspecification and deprecate old #32857

feat(dynamodb): add pointintimerecoveryspecification and deprecate old #32857

Conversation

LeeroyHannigan commented Jan 11, 2025

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

codecov bot commented Jan 12, 2025 • edited Loading

Codecov Report

aws-cdk-automation commented Jan 12, 2025

AWS CodeBuild CI Report

GavinZZ left a comment

Choose a reason for hiding this comment

GavinZZ Jan 16, 2025

Choose a reason for hiding this comment

GavinZZ Jan 16, 2025

Choose a reason for hiding this comment

LeeroyHannigan Jan 16, 2025

Choose a reason for hiding this comment

GavinZZ Jan 16, 2025

Choose a reason for hiding this comment

GavinZZ Jan 16, 2025

Choose a reason for hiding this comment

aws-cdk-automation commented Jan 17, 2025

aws-cdk-automation commented Jan 18, 2025

aws-cdk-automation commented Jan 19, 2025

aws-cdk-automation commented Jan 20, 2025

LeeroyHannigan commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

codecov bot commented Jan 12, 2025 •

edited

Loading