Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: testing pr linter codecov exemptions #32866

Closed
wants to merge 1 commit into from

Conversation

iliapolo
Copy link
Contributor

IGNORE

@iliapolo iliapolo requested a review from a team as a code owner January 12, 2025 19:31
@github-actions github-actions bot added the p2 label Jan 12, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team January 12, 2025 19:31
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 12, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.29%. Comparing base (b49c116) to head (58a6ff5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #32866      +/-   ##
==========================================
- Coverage   81.38%   81.29%   -0.09%     
==========================================
  Files         222      222              
  Lines       13695    13695              
  Branches     2412     2412              
==========================================
- Hits        11145    11134      -11     
- Misses       2271     2283      +12     
+ Partials      279      278       -1     
Flag Coverage Δ
suite.unit 81.29% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.53% <ø> (-0.16%) ⬇️
packages/aws-cdk-lib/core 82.09% <ø> (ø)

@iliapolo iliapolo added the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 12, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 12, 2025 19:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@iliapolo iliapolo removed the pr-linter/exempt-codecov The PR linter will not require codecov checks to pass label Jan 12, 2025
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 58a6ff5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ codecov/patch job is not succeeding
❌ codecov/patch/packages/aws-cdk job is not succeeding
❌ codecov/patch/packages/aws-cdk-lib/core job is not succeeding
❌ codecov/project job is not succeeding
❌ codecov/project/packages/aws-cdk job is not succeeding
❌ codecov/project/packages/aws-cdk-lib/core job is not succeeding

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@iliapolo iliapolo closed this Jan 12, 2025
@iliapolo iliapolo deleted the epolon/testing-pr-linter-codecov branch January 12, 2025 20:13
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants