Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix changedir when unpacking tar/tgz #396

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix changedir when unpacking tar/tgz #396

wants to merge 1 commit into from

Conversation

andogq
Copy link

@andogq andogq commented Jun 4, 2024

Issue #, if available: N/A

Description of changes:

When running multiple deployments with a tar/tgz bundle on the same host with the same codeagent instance, there is a chance for a race condition at the DownloadBundle step where it may fail with a variety of error messages (eg):

  • Error extracting tar archive:
  • conflicting chdir during another chdir block

This change removes the use of FileUtils.cd when spawning the tar command in favour for tar's -C option which sets the changes the directory when running the command. This resolves any contention on the current directory as the directory is changed within each process' respective shells.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dnjohnson
Copy link

Can confirm this problem is affecting us in production and the proposed patch addresses the issue. Highly recommend 👍

@sebastianreloaded
Copy link

It is 3+ years and there is still no fully working version for ubuntu 22.04+ (#301) - baffling
Thx again to @moosthuizen42 for keeping codedeploy usable ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants