-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(RSA): limit RSA Key Gen to 4096 bits #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact that CI accepted this without any failures is a big problem.
Thinking more deeply beyond the initial reaction (just wanted to block the PR in case): is this all we need to do because all callers of the method already satisfy this precondition? I was worried about this being indirectly callable from outside Dafny. |
In response to @robin-aws concerns, |
4096 is the KMS Max, so we are going to refactor to that. |
Concerns put to rest - I managed to miss the fact that this existing in |
Issue #, if available: N/A
Description of changes:
This does NOT impact the public behavior of the ESDK in any way.
The RSA Key Generator is ONLY used for testing.
4096 is the largest RSA Key size KMS supports.
Squash/merge commit message, if applicable:
chore(RSA): limit RSA Key Gen to 4096 bits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Due to dafny-lang/dafny#2500, Traits are dangerous:
{:termination false}
?The override checks on
the specifications on
a class' functions/methods/etc. validating
that specifications are
at least as strong as those on
the traits it implements
are not working correctly when
that trait is defined in a different module
(and hence must have
{:termination false}
on it).As such, if either (1.) or (2.) is true: