Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace Portable BC with BC Crypto #614

Closed
wants to merge 1 commit into from

Conversation

texastony
Copy link
Contributor

Issue #, if available:

Description of changes:
It does not appear that BouncyCastle is going to continue development of
Portable.BouncyCastle, which apparently is a labor of love/brilliance by one developer.

Instead, they seem to be committing to BouncyCastle.Cryptography.

See: https://www.bouncycastle.org/csharp/#DOWNLOAD20200

Squash/merge commit message, if applicable:
chore: replace Portable BC with BC Crypto

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Due to dafny-lang/dafny#2500, Traits are dangerous:

  1. Does this PR add any traits or classes that extend a trait?
  2. Are these traits annotated with {:termination false}?

The override checks on
the specifications on
a class' functions/methods/etc. validating
that specifications are
at least as strong as those on
the traits it implements
are not working correctly when
that trait is defined in a different module
(and hence must have {:termination false} on it).

As such, if either (1.) or (2.) is true:

  • manually verified all the trait specifications are copied onto classes that extend them?

@texastony texastony requested a review from a team as a code owner August 29, 2023 03:42
@texastony
Copy link
Contributor Author

NVM, Package BouncyCastle.Cryptography 2.2.1 is not compatible with net452 (.NETFramework,Version=v4.5.2)

@texastony texastony closed this Aug 29, 2023
@texastony texastony deleted the tony/replace-BC-portable branch November 29, 2023 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant