-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: only run net48 on windows and use node 17 to run integration-node #639
Conversation
os: [ | ||
windows-latest, | ||
ubuntu-latest, | ||
macos-latest, | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: I think I never figured out Zip file creation on Windows.
So this Job cannot work on Windows.
See line 170 or the step that creates the Zip.
# - name: Fetch awses-decrypt/python-2.3.0.zip | ||
# working-directory: ./ | ||
# shell: bash | ||
# run: | | ||
# PYTHON_23_VECTOR_PATH=$GITHUB_WORKSPACE/python23/vectors | ||
# mkdir -p $PYTHON_23_VECTOR_PATH | ||
# DOWNLOAD_NAME=python23.zip | ||
# curl --no-progress-meter --output $DOWNLOAD_NAME --location $VECTORS_URL | ||
# unzip -o -qq $DOWNLOAD_NAME -d $PYTHON_23_VECTOR_PATH | ||
# rm $DOWNLOAD_NAME |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question/Issue: Why not just delete this content?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing stuff out, not want to delete this yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve with suggestion
# - name: Generate Test Vectors with .NET Framework net6.0 | ||
# # TODO Post-#619: Fix Zip file creation on Windows | ||
# if: matrix.os != 'windows-latest' | ||
# working-directory: ./AwsEncryptionSDK | ||
# shell: bash | ||
# run: | | ||
# NET_41_VECTOR_PATH=$GITHUB_WORKSPACE/net41/vectors | ||
# mkdir -p $NET_41_VECTOR_PATH | ||
# GEN_PATH=runtimes/net/TestVectorsNative/TestVectorGenerator | ||
# dotnet run --project $GEN_PATH --framework net6.0 -- \ | ||
# --encrypt-manifest $GEN_PATH/resources/0006-awses-message-decryption-generation.v2.json \ | ||
# --output-dir $NET_41_VECTOR_PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to leave it to come back to fix the zip on windows problem
## 4.1.0 ### Notes - [(#646)](10daadf) Enforces input constraints. Prior to this fix, the AWS Encryption SDK in .NET (ESDK-NET) failed to enforce user input constraints. Input shapes without required members set would always result in a `NullReferenceException`. Now, the ESDK-NET will throw its own Exceptions when illegal user input is submitted. ### Fixes * fix: throw an exception when MemoryStream instance has an empty backing array [(#633)](550c714) ### Features * feat: enforce input constraints [(#646)](10daadf) ### Maintenance * fix(CI): Daily CI uses correct workflow [(#641)](771835e) * chore(ci): fix role to assume [(#622)](c1f04fc) * chore(CI/CD): add semantic release automation [(#647)](e7b5392) * chore: Adopt SmithyDafnyMakefile.mk, fix nightly build [(#638)](cd19979) * chore(CI): add interop tests to daily ci [(#640)](c9ad018) * chore: only run net48 on windows and use node 17 to run integration-node [(#639)](d6c62fb) * chore(.NET): Add ESDK-Net v4.0.1 generated vectors[(#636)](efef497) * chore(NET-SupportPolicy): Mark 3.x as Support [(#631)](3c36f7a) * chore: Add manual trigger for nightly_dafny.yml [(#629)](419b1cb) * chore: split vc gen on some methods to migrate to Dafny 4.4 [(#627)](fdc65ca) * test: restore CODEOWNERS and daily CI [(#624)](ff823ac) * chore: update template to point to public repo [(#626)](2b07a39) * chore: remove unused release step in test-prod [(#623)](9883933)
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.