Add EFA NCCL test case, unmanaged nodegroup template #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermckinnon
force-pushed
the
efa-nccl-test
branch
from
59a3ce0
to
77a7bcb
Compare
cartermckinnon
commented
Feb 23, 2024
| containers: | ||
| - image: public.ecr.aws/w6p6i9i7/aws-efa-nccl-rdma:22.03-pt-py3 | ||
| - image: TODO |
There was a problem hiding this comment.
Temporary until there's an build pipeline set up for the image added in this PR.
cartermckinnon
commented
Feb 23, 2024
| - FI_LOG_LEVEL=warn | ||
| - -x | ||
| - FI_EFA_USE_DEVICE_RDMA=1 | ||
| - -x | ||
| - OFI_NCCL_DISABLE_GDR_REQUIRED_CHECK=0 |
There was a problem hiding this comment.
This is important, it will fail the test case if something goes wrong with the EFA RDMA instead of falling back to the dirt-slow host buffer copy.
Issacwww
reviewed
Feb 23, 2024
| @@ -52,6 +52,7 @@ spec: | |||
| - p4de.24xlarge | |||
| - trn1.32xlarge | |||
| - trn1n.32xlarge | |||
| - p5.48xlarge | |||
There was a problem hiding this comment.
do we have some control over it so that we can easily tune/stabilize the test?
There was a problem hiding this comment.
This is adding p5 types to the nodeSelector for the EFA device plugin, it's just a pre-req for using p5's.
Issacwww
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds a new option to the eksapi deployer,
--efa, which will create an EFA-enabled unmanaged nodegroup.It also adds a case to the nvidia e2e tests to perform an AllReduce operation using 2 workers on EFA-enabled nodes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.