capacity-resevation requries efa #480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issacwww
force-pushed
the
capacityreservationfix
branch
from
14d3d10
to
7a8848f
Compare
bryantbiggs
reviewed
Nov 5, 2024
| @@ -245,6 +245,9 @@ func (d *deployer) verifyUpFlags() error { | |||
| d.UserDataFormat = "bootstrap.sh" | |||
| klog.V(2).Infof("Using default user data format: %s", d.UserDataFormat) | |||
| } | |||
| if d.CapacityReservation && !d.EFA{ | |||
There was a problem hiding this comment.
not sure if its an implementation detail here, but there is no link between EFA and capacity reservations. There is, however, a requirement for nodes connected via EFA need to be in the same AZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.