Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for nvidia instance type when use static cluster #504

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Issacwww
Copy link
Contributor

@Issacwww Issacwww commented Nov 8, 2024

Issue #, if available:

Description of changes:
due to the capacity for efa gpu instance, need to use dynamic way to select different instance type for efa and non-efa test. for now only add support for nvidia as the rest variants don't have efa test yet.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Issacwww Issacwww force-pushed the supportStaticClusterInstanceType branch from 33a9f0a to 015f7b7 Compare November 8, 2024 11:12
@Issacwww Issacwww force-pushed the supportStaticClusterInstanceType branch from 015f7b7 to 8bb26bf Compare November 8, 2024 17:52
@Issacwww Issacwww enabled auto-merge (squash) November 8, 2024 17:53
Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Issacwww Issacwww merged commit 8d36c24 into aws:main Nov 8, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants