Add support for nccom test for neuron instances #505
Merged
+9,175
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Add support for nccom test for neuron instances
Description of changes:
We run nccl_test with mpirun. mpioperator understands mpirun command, sets up all required config and connectivity for running mpijob.
nccom_test uses nccom binary. We need to pass in worker pod IP's while issuing the nccom command and it also needs ssh connectivity between pods. We don't have a similar support as in nccl_test to run nccom_test within containers. To make this work, added some ssh config in dockerfile and retrieved worker pod IPs dynamically in the manifest via launcher init container.
Some part of the code to setup dependencies (efa device plugin, mpioperator, getting instance details) is taken from current nccl_test code.
More important files to review would be
e2e2/test/cases/neuron/manifests/multi-node-test-neuron.yaml
e2e2/test/cases/nvidia/manifests/efa-device-plugin.yaml
Testing
Skipped adding all info and debug logs in between
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.