Skip to content

Commit

Permalink
Remove Node14 from integ tests matrix since it is deprecated
Browse files Browse the repository at this point in the history
  • Loading branch information
andclt committed Feb 14, 2024
1 parent b6b3656 commit f283247
Show file tree
Hide file tree
Showing 13 changed files with 4 additions and 149 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ You can include this package in your preferred base image to make that base imag

## Requirements
The NodeJS Runtime Interface Client package currently supports NodeJS versions:
- 14.x
- 16.x
- 18.x
- 20.x
Expand Down
1 change: 0 additions & 1 deletion test/integration/codebuild/buildspec.os.alpine.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ batch:
DISTRO_VERSION:
- "3.16"
RUNTIME_VERSION:
- "14"
- "16"
- "18"
phases:
Expand Down
4 changes: 2 additions & 2 deletions test/integration/codebuild/buildspec.os.alpine.2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ batch:
env:
variables:
DISTRO_VERSION:
- "3.16"
- "3.18"
RUNTIME_VERSION:
- "14"
- "20"
phases:
pre_build:
commands:
Expand Down
102 changes: 0 additions & 102 deletions test/integration/codebuild/buildspec.os.alpine.4.yml

This file was deleted.

1 change: 0 additions & 1 deletion test/integration/codebuild/buildspec.os.centos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ batch:
- "stream8"
- "stream9"
RUNTIME_VERSION:
- "14"
- "16"
- "18"
- "20"
Expand Down
1 change: 0 additions & 1 deletion test/integration/codebuild/buildspec.os.debian.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ batch:
- "buster"
- "bullseye"
RUNTIME_VERSION:
- "14"
- "16"
- "18"
- "20"
Expand Down
1 change: 0 additions & 1 deletion test/integration/codebuild/buildspec.os.ubuntu.1.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ batch:
- "20.04"
- "22.04"
RUNTIME_VERSION:
- "14"
- "16"
phases:
pre_build:
Expand Down
5 changes: 0 additions & 5 deletions test/integration/docker/Dockerfile.echo.alpine
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down
17 changes: 2 additions & 15 deletions test/integration/docker/Dockerfile.echo.amazonlinux
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,8 @@ ARG DISTRO_VERSION
# Install Py3 required to build Node16+
RUN if [[ "${DISTRO_VERSION}" == "2" ]] ; then amazon-linux-extras install python3.8 && update-alternatives --install /usr/bin/python3 python3 /usr/bin/python3.8 1 ; fi
# Install NodeJS
RUN if [[ "${RUNTIME_VERSION}" == "14" ]]; then \
yum install -y tar gzip xz && \
AARCH="$([[ "$(arch)" == "x86_64" ]] && echo "x64" || echo "arm64")" && \
NODE_URL="https://nodejs.org/download/release/v14.21.3/node-v14.21.3-linux-$AARCH.tar.xz" && \
curl -fL "$NODE_URL" | tar -C /usr --strip-components 1 -xJf - && \
yum clean all -q && rm -rf /var/cache/yum ; \
else \
yum install https://rpm.nodesource.com/pub_${RUNTIME_VERSION}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y && \
yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1s ; \
fi
RUN yum install https://rpm.nodesource.com/pub_${RUNTIME_VERSION}.x/nodistro/repo/nodesource-release-nodistro-1.noarch.rpm -y && \
yum install nodejs -y --setopt=nodesource-nodejs.module_hotfixes=1s;

# Stage 2 - build function and dependencies
FROM node-amazonlinux AS build-image
Expand Down Expand Up @@ -50,11 +42,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down
5 changes: 0 additions & 5 deletions test/integration/docker/Dockerfile.echo.centos
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down
5 changes: 0 additions & 5 deletions test/integration/docker/Dockerfile.echo.debian
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down
5 changes: 0 additions & 5 deletions test/integration/docker/Dockerfile.echo.ubuntu
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [ $(node -v | cut -c 1-3) = "v14" ] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down
5 changes: 0 additions & 5 deletions test/integration/docker/Dockerfile.programmatic.alpine
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ RUN mkdir -p ${FUNCTION_DIR}
WORKDIR ${FUNCTION_DIR}/deps/aws-lambda-ric
COPY . .

# Node14 uses [email protected] by default which will downgrade permissions, if it's root,
# before running any build scripts: https://github.com/npm/npm/issues/3497
# Starting from [email protected], when npm is run as root,
# scripts are always run with the effective uid and gid of the working directory owner.
RUN if [[ $(node -v | cut -c 1-3) == "v14" ]] ; then npm install -g npm@7 ; fi
RUN make build && \
npm run test:unit

Expand Down

0 comments on commit f283247

Please sign in to comment.