-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove native dependencies. #8
base: main
Are you sure you want to change the base?
Conversation
Use the http module for all the runtime interactions. Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
+1 for landing this. The current v1.0.0 release doesn't always work correctly in multi-stage builds — I install all build-time dependencies in the first builder stage, install this package, then copy This PR vastly simplifies the package, makes it easier to maintain and contribute to, and embraces Node's native capabilities. |
Looks like this PR will resolve #28 ? |
We are facing the same issue with CENT OS- Can someone please let us know when this fix will be available? Or till then if there is any workaround then please let us know. |
How this has still not been merged is truly beyond me. /preinstall.sh continues to fail for the weirdest reasons. |
Any chance we can get this PR merged in? I'm not able to use a custom CentOS 7 docker image with my lambda. Getting the same error that's reported in #14 |
Getting this PR merged would be very helpful, the pre-build script is causing issues with this package on our CI server. We aren't even using anything that gets built. |
@jbutz AWS literally couldn't care less, I wouldn't hold out any hope of them responding to any PRs or merging anything here. |
It was easier and faster to migrate my lambda to python than to get AWS to fix this node module. |
i had to install |
I published https://www.npmjs.com/package/@stevenmerrill/aws-lambda-ric as |
Just done the same 😬 |
Use the http module for all the runtime interactions.
This change allows the interface to work on MacOS and Windows, since it doesn't depend on Linux native code anymore.
I've tested these changes with the emulator and they seem to be working as expected.
I think this is a better option than #4
/cc @mraerino
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.