Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove native dependencies. #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

calavera
Copy link

@calavera calavera commented Jan 8, 2021

Use the http module for all the runtime interactions.

This change allows the interface to work on MacOS and Windows, since it doesn't depend on Linux native code anymore.

I've tested these changes with the emulator and they seem to be working as expected.

I think this is a better option than #4

/cc @mraerino

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Use the http module for all the runtime interactions.

Signed-off-by: David Calavera <[email protected]>
Signed-off-by: David Calavera <[email protected]>
@paambaati
Copy link

+1 for landing this. The current v1.0.0 release doesn't always work correctly in multi-stage builds — I install all build-time dependencies in the first builder stage, install this package, then copy node_modules over to the next stage. It refuses to run because of a missing runtime dependency, nghttp2-libs.

This PR vastly simplifies the package, makes it easier to maintain and contribute to, and embraces Node's native capabilities.

@missinglink
Copy link

Looks like this PR will resolve #28 ?

@piyushhajare
Copy link

piyushhajare commented Aug 4, 2021

We are facing the same issue with CENT OS-
/aws-lambda-ric/build/Release/runtime-client.node: undefined symbol: _ZN3aws14lambda_runtime7runtimeC1ERKSsS3

Can someone please let us know when this fix will be available? Or till then if there is any workaround then please let us know.

@donn
Copy link

donn commented Nov 7, 2021

How this has still not been merged is truly beyond me. /preinstall.sh continues to fail for the weirdest reasons.

@anthony-telljohann
Copy link

Any chance we can get this PR merged in? I'm not able to use a custom CentOS 7 docker image with my lambda. Getting the same error that's reported in #14

@jbutz
Copy link

jbutz commented Jun 9, 2022

Getting this PR merged would be very helpful, the pre-build script is causing issues with this package on our CI server. We aren't even using anything that gets built.

@missinglink
Copy link

@jbutz AWS literally couldn't care less, I wouldn't hold out any hope of them responding to any PRs or merging anything here.

@anthony-telljohann
Copy link

It was easier and faster to migrate my lambda to python than to get AWS to fix this node module.

@paolomainardi
Copy link

i had to install nghttp2-libs on a custom alpine docker multi-stage build image, i cannot find any reference on the official doc.

@smerrill
Copy link

smerrill commented Nov 23, 2022

I published https://www.npmjs.com/package/@stevenmerrill/aws-lambda-ric as current main branch v1.0.0 with this PR merged. This is totally unsupported; use at your own risk.

@cooper667
Copy link

It was easier and faster to migrate my lambda to python than to get AWS to fix this node module.

Just done the same 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.