AVX-512 support for RSA Signing #1273
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| name: MinGW | ||
| on: | ||
| pull_request: | ||
| branches: [ '*' ] | ||
| push: | ||
| branches: [ '*' ] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number }} | ||
| cancel-in-progress: true | ||
| jobs: | ||
| mingw: | ||
| if: github.repository == 'aws/aws-lc' | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Install NASM | ||
| uses: ilammy/[email protected] | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - name: Setup MinGW | ||
| uses: egor-tensin/[email protected] | ||
| id: setup_mingw | ||
| with: | ||
| static: 0 | ||
| - name: Setup CMake | ||
| uses: threeal/[email protected] | ||
| with: | ||
| generator: Ninja | ||
| c-compiler: ${{ steps.setup_mingw.outputs.gcc }} | ||
| cxx-compiler: ${{ steps.setup_mingw.outputs.gxx }} | ||
| options: | | ||
| CMAKE_SYSTEM_NAME=Windows \ | ||
| CMAKE_SYSTEM_PROCESSOR=x86_64 \ | ||
| CMAKE_BUILD_TOOL=C:/ProgramData/chocolatey/lib/mingw/tools/install/mingw64/bin/ninja.exe \ | ||
| CMAKE_FIND_ROOT_PATH=C:/ProgramData/chocolatey/lib/mingw/tools/install/mingw64 \ | ||
| CMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER \ | ||
| CMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY \ | ||
| CMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY \ | ||
| - name: Build Project | ||
| run: cmake --build ./build --target all | ||
| - name: Run tests | ||
| run: cmake --build ./build --target run_tests | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,54 +75,20 @@ | |
| *STDOUT=*OUT; | ||
|
|
||
| if ($avx512ifma>0) {{{ | ||
|
|
||
| @_6_args_universal_ABI = $win64 ? | ||
| ("%rcx","%rdx","%r8","%r9","%r10","%r11") : | ||
| ("%rdi","%rsi","%rdx","%rcx","%r8","%r9"); | ||
|
|
||
| ############################################################################### | ||
| # void rsaz_amm52x20_x1_ifma256(BN_ULONG *res, | ||
| # const BN_ULONG *a, | ||
| # const BN_ULONG *b, | ||
| # const BN_ULONG *m, | ||
| # BN_ULONG k0); | ||
| ############################################################################### | ||
| { | ||
| # input parameters | ||
| my ($res,$a,$b,$m,$k0) = @_6_args_universal_ABI; | ||
|
There was a problem hiding this comment. It's not clear to me if this takes win64 into account. There was a problem hiding this comment. I think you're right, I don't think it is either! I've updated this with a ternary check. |
||
|
|
||
| my $mask52 = "%rax"; | ||
|
|
@@ -325,10 +291,10 @@ sub amm52x20_x1_norm { | |
| $code.=<<___; | ||
| .text | ||
|
|
||
| .globl rsaz_amm52x20_x1_ifma256 | ||
| .type rsaz_amm52x20_x1_ifma256,\@function,5 | ||
| .align 32 | ||
| rsaz_amm52x20_x1_ifma256: | ||
| .cfi_startproc | ||
| endbranch | ||
|
There was a problem hiding this comment. Just to confirm my understanding, this is effectively the same as aws-lc/include/openssl/asm_base.h Line 63 in 518df30 There was a problem hiding this comment. When CET is available, yes. Here is its definition in GCC, where |
||
| push %rbx | ||
|
|
@@ -343,7 +309,7 @@ sub amm52x20_x1_norm { | |
| .cfi_push %r14 | ||
| push %r15 | ||
| .cfi_push %r15 | ||
| .Lrsaz_amm52x20_x1_ifma256_body: | ||
|
|
||
| # Zeroing accumulators | ||
| vpxord $zero, $zero, $zero | ||
|
|
@@ -396,10 +362,10 @@ sub amm52x20_x1_norm { | |
| .cfi_restore %rbx | ||
| lea 48(%rsp),%rsp | ||
| .cfi_adjust_cfa_offset -48 | ||
| .Lrsaz_amm52x20_x1_ifma256_epilogue: | ||
| ret | ||
| .cfi_endproc | ||
| .size rsaz_amm52x20_x1_ifma256, .-rsaz_amm52x20_x1_ifma256 | ||
| ___ | ||
|
|
||
| $code.=<<___; | ||
|
|
@@ -414,27 +380,20 @@ sub amm52x20_x1_norm { | |
| ___ | ||
|
|
||
| ############################################################################### | ||
| # void rsaz_amm52x20_x2_ifma256(BN_ULONG out[2][20], | ||
| # const BN_ULONG a[2][20], | ||
| # const BN_ULONG b[2][20], | ||
| # const BN_ULONG m[2][20], | ||
| # const BN_ULONG k0[2]); | ||
| ############################################################################### | ||
|
|
||
| $code.=<<___; | ||
| .text | ||
|
|
||
| .globl rsaz_amm52x20_x2_ifma256 | ||
| .type rsaz_amm52x20_x2_ifma256,\@function,5 | ||
| .align 32 | ||
| rsaz_amm52x20_x2_ifma256: | ||
| .cfi_startproc | ||
| endbranch | ||
| push %rbx | ||
|
|
@@ -449,7 +408,7 @@ sub amm52x20_x1_norm { | |
| .cfi_push %r14 | ||
| push %r15 | ||
| .cfi_push %r15 | ||
| .Lrsaz_amm52x20_x2_ifma256_body: | ||
|
|
||
| # Zeroing accumulators | ||
| vpxord $zero, $zero, $zero | ||
|
|
@@ -514,27 +473,18 @@ sub amm52x20_x1_norm { | |
| .cfi_restore %rbx | ||
| lea 48(%rsp),%rsp | ||
| .cfi_adjust_cfa_offset -48 | ||
| .Lrsaz_amm52x20_x2_ifma256_epilogue: | ||
| ret | ||
| .cfi_endproc | ||
| .size rsaz_amm52x20_x2_ifma256, .-rsaz_amm52x20_x2_ifma256 | ||
| ___ | ||
| } | ||
|
|
||
| ############################################################################### | ||
| # void extract_multiplier_2x20_win5(BN_ULONG *red_Y, | ||
| # const BN_ULONG red_table[1 << EXP_WIN_SIZE][2][20], | ||
| # int red_table_idx1, int red_table_idx2); | ||
| # | ||
| ############################################################################### | ||
| { | ||
| # input parameters | ||
|
|
@@ -553,9 +503,9 @@ sub amm52x20_x1_norm { | |
| .text | ||
|
|
||
| .align 32 | ||
| .globl extract_multiplier_2x20_win5 | ||
| .type extract_multiplier_2x20_win5,\@abi-omnipotent | ||
| extract_multiplier_2x20_win5: | ||
| .cfi_startproc | ||
| endbranch | ||
| vmovdqa64 .Lones(%rip), $ones # broadcast ones | ||
|
|
@@ -597,7 +547,7 @@ sub amm52x20_x1_norm { | |
| $code.=<<___; | ||
| ret | ||
| .cfi_endproc | ||
| .size extract_multiplier_2x20_win5, .-extract_multiplier_2x20_win5 | ||
| ___ | ||
| $code.=<<___; | ||
| .section .rodata | ||
|
|
@@ -707,47 +657,39 @@ sub amm52x20_x1_norm { | |
|
|
||
| .section .pdata | ||
| .align 4 | ||
| .rva .LSEH_begin_rsaz_amm52x20_x1_ifma256 | ||
| .rva .LSEH_end_rsaz_amm52x20_x1_ifma256 | ||
| .rva .LSEH_info_rsaz_amm52x20_x1_ifma256 | ||
|
|
||
| .rva .LSEH_begin_rsaz_amm52x20_x2_ifma256 | ||
| .rva .LSEH_end_rsaz_amm52x20_x2_ifma256 | ||
| .rva .LSEH_info_rsaz_amm52x20_x2_ifma256 | ||
|
|
||
| .section .xdata | ||
| .align 8 | ||
| .LSEH_info_rsaz_amm52x20_x1_ifma256: | ||
| .byte 9,0,0,0 | ||
| .rva rsaz_def_handler | ||
| .rva .Lrsaz_amm52x20_x1_ifma256_body,.Lrsaz_amm52x20_x1_ifma256_epilogue | ||
| .LSEH_info_rsaz_amm52x20_x2_ifma256: | ||
| .byte 9,0,0,0 | ||
| .rva rsaz_def_handler | ||
| .rva .Lrsaz_amm52x20_x2_ifma256_body,.Lrsaz_amm52x20_x2_ifma256_epilogue | ||
| ___ | ||
| } | ||
| }}} else {{{ # fallback for old assembler | ||
| $code.=<<___; | ||
| .text | ||
| .globl rsaz_amm52x20_x1_ifma256 | ||
| .globl rsaz_amm52x20_x2_ifma256 | ||
| .globl extract_multiplier_2x20_win5 | ||
| .type rsaz_amm52x20_x1_ifma256,\@abi-omnipotent | ||
| rsaz_amm52x20_x1_ifma256: | ||
| rsaz_amm52x20_x2_ifma256: | ||
| extract_multiplier_2x20_win5: | ||
| .byte 0x0f,0x0b # ud2 | ||
| ret | ||
| .size rsaz_amm52x20_x1_ifma256, .-rsaz_amm52x20_x1_ifma256 | ||
| ___ | ||
| }}} | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this? Is this not covered by our existing intel SDE tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure how this file got into this PR. This appears to be a duplicate of CI tests we already have: https://github.com/aws/aws-lc/blob/main/.github/workflows/windows-alt.yml#L11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It must have come in with an intermediate merge somewhere along the way. I will remove it.