Dockerfile and structure change for SAW proofs on X86_64 #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pennyannn
force-pushed
the
yppe/fix-saw-build
branch
from
3f3e0f9
to
7bb88b4
Compare
nebeid
reviewed
Dec 6, 2023
nebeid
approved these changes
Dec 6, 2023
samuel40791765
approved these changes
Dec 6, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
=======================================
Coverage 76.72% 76.72%
=======================================
Files 422 422
Lines 71190 71190
=======================================
+ Hits 54617 54619 +2
+ Misses 16573 16571 -2 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
None
Description of changes:
One pending merge PR (awslabs/aws-lc-verification#128) in AWS-LC-verification will change the Dockerfile name for SAW proofs on X86_64 and will change where the shell scripts are for running the proofs. This is a coordination PR to make sure that once that PR is merged, AWS-LC CI will continue to run smoothly.
Call-outs:
None
Testing:
Changes are tested by downloading existing docker image
aws-lc-docker-images-linux-x86:ubuntu-20.04_clang-10x_formal-verification_latest, and running the proofs in the AWS-LC-verification PR (awslabs/aws-lc-verification#128) within the docker image using adjusted commands from the scriptrun_formal_verification.sh.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.