Add misc. x509 un/lock and set1 functions #1449
Merged
+144
−8
Commits on Feb 29, 2024
-
Add misc. x509 un/lock and set1 functions
The set1 functions are cribbed from [OpenSSL's implementation][1], but notably differ in that we don't free the `X509_OBJECT`. This is pursuant to OpenSSL's [own convention][2] around "set1" functions: > In the 1 version the ownership of the object is not passed to or > retained by the parent object. Instead a copy or "up ref" of the > object is performed. OpenSSL [frees][3] the input `X509_OBJECT`; we do not. [1]: https://github.com/openssl/openssl/blob/4a6f70c03182b421d326831532edca32bcdb3fb1/crypto/x509/x509_lu.c#L506 [2]: https://www.openssl.org/docs/man3.2/man7/ossl-guide-libraries-introduction.html [3]: https://github.com/openssl/openssl/blob/4a6f70c03182b421d326831532edca32bcdb3fb1/crypto/x509/x509_lu.c#L511
-
Remove random jitter to appease MacOS in CI
This commit was made because the MacOS CI jobs [seem to have taken issue][1] with how we were doing things previously. [1]: https://github.com/aws/aws-lc/actions/runs/8014000000/job/21891957419?pr=1449
-
-
-
-
-
Update crypto/x509/x509_test.cc
Co-authored-by: Andrew Hopkins <[email protected]>
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.