Avoid out of range pc-relative fixup value #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
+ Coverage 76.87% 76.91% +0.04%
==========================================
Files 425 425
Lines 71571 71571
==========================================
+ Hits 55020 55050 +30
+ Misses 16551 16521 -30 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
fix-arm-linux-androideabi
branch
2 times, most recently
from
94e5d62
to
e310388
Compare
torben-hansen
previously approved these changes
Feb 28, 2024
nebeid
reviewed
Feb 28, 2024
justsmth
force-pushed
the
fix-arm-linux-androideabi
branch
from
459f531
to
1d7fc9f
Compare
justsmth
force-pushed
the
fix-arm-linux-androideabi
branch
from
1d7fc9f
to
36ae825
Compare
nebeid
approved these changes
Feb 28, 2024
torben-hansen
approved these changes
Feb 29, 2024
justsmth
added a commit
to justsmth/aws-lc
that referenced
this pull request
Mar 1, 2024
* Addresses failure [seen here](https://github.com/aws/aws-lc-rs/actions/runs/8019806331/job/21908336880?pr=340#step:8:480) on `arm-linux-androideabi`. ``` /tmp/sha256-armv4-f3213e.s:1455:2: error: out of range pc-relative fixup value adr r14,K256 ^ ``` * Fix extracted from this [recent upstream commit](google/boringssl@12316ab). * Extended `aws-lc-rs` CI test to provide better coverage of the older arm (< v7) cpus. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
arm-linux-androideabi.aws-lc-rsCI test to provide better coverage of the older arm (< v7) cpus.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.