Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding OPENSSL_secure_zalloc and BIO_s_secmem #1476

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Mar 6, 2024

Description of changes:

Added BIO_s_secmem and OPENSSL_secure_zalloc. These functions are related to Secure Heaps which aren't supported in AWS-LC. Therefore, these functions use their normal alternatives (BIO_s_mem and OPENSSL_zalloc).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@smittals2 smittals2 requested a review from a team as a code owner March 6, 2024 02:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 77.17%. Comparing base (c5d38a5) to head (69a0fbf).

Files Patch % Lines
crypto/bio/bio_mem.c 0.00% 2 Missing ⚠️
crypto/mem.c 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   77.18%   77.17%   -0.01%     
==========================================
  Files         426      426              
  Lines       71449    71452       +3     
==========================================
  Hits        55146    55146              
- Misses      16303    16306       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crypto/mem.c Show resolved Hide resolved
include/openssl/bio.h Outdated Show resolved Hide resolved
Copy link
Contributor

@samuel40791765 samuel40791765 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not trying to nitpick the wording here. But in the PR description and final commit message, could we replace "un-secure alternatives" with something else? It could make things seem scary and insecure, but in reality we're just pointing to the traditional alternatives.
It'd also help to clarify that these are "no-ops" in the PR title, since we aren't actually implementing secure heap versions of the functions.

crypto/mem.c Show resolved Hide resolved
include/openssl/mem.h Show resolved Hide resolved
@smittals2 smittals2 changed the title Added Secure Heap versions of zalloc and BIO_s_mem Added Secure Heap versions of OPENSSL_zalloc and BIO_s_mem as no-ops Mar 6, 2024
@justsmth justsmth changed the title Added Secure Heap versions of OPENSSL_zalloc and BIO_s_mem as no-ops Adding OPENSSL_secure_zalloc and BIO_s_secmem Mar 7, 2024
include/openssl/bio.h Outdated Show resolved Hide resolved
include/openssl/mem.h Outdated Show resolved Hide resolved
samuel40791765
samuel40791765 previously approved these changes Mar 27, 2024
include/openssl/mem.h Outdated Show resolved Hide resolved
justsmth
justsmth previously approved these changes Apr 15, 2024
@smittals2 smittals2 merged commit ca72f77 into aws:main Apr 17, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants