Support for MinGW on Windows #1492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
+ Coverage 76.96% 76.98% +0.01%
==========================================
Files 426 426
Lines 71738 71738
==========================================
+ Hits 55211 55225 +14
+ Misses 16527 16513 -14 ☔ View full report in Codecov by Sentry. |
justsmth
force-pushed
the
support-mingw
branch
10 times, most recently
from
462e490
to
fd4a535
Compare
andrewhop
reviewed
Mar 19, 2024
justsmth
force-pushed
the
support-mingw
branch
4 times, most recently
from
350c47c
to
b3f1972
Compare
andrewhop
reviewed
Mar 20, 2024
skmcgrail
previously approved these changes
Mar 21, 2024
auto-merge was automatically disabled
March 22, 2024 02:21
Head branch was pushed to by a user without write access
justinwsmith
force-pushed
the
support-mingw
branch
from
37bde28
to
4ddc6d4
Compare
justinwsmith
force-pushed
the
support-mingw
branch
4 times, most recently
from
071d349
to
74b4021
Compare
justinwsmith
force-pushed
the
support-mingw
branch
from
74b4021
to
2d2e86d
Compare
justsmth
force-pushed
the
support-mingw
branch
2 times, most recently
from
65b2776
to
d44e08a
Compare
justsmth
force-pushed
the
support-mingw
branch
2 times, most recently
from
17ac61d
to
c39d658
Compare
auto-merge was automatically disabled
March 22, 2024 21:41
Head branch was pushed to by a user without write access
justinwsmith
force-pushed
the
support-mingw
branch
from
c39d658
to
ec49a15
Compare
skmcgrail
approved these changes
Mar 28, 2024
andrewhop
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Description of changes:
Testing
All tests passed on my Windows Server 2022 Datacenter EC2 instance.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.