Bump mysql integration CI to 8.3 #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuel40791765
force-pushed
the
mysql-8.3
branch
from
858bdf8
to
67a10b3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 77.00% 76.98% -0.03%
==========================================
Files 425 425
Lines 71556 71556
==========================================
- Hits 55103 55087 -16
- Misses 16453 16469 +16 ☔ View full report in Codecov by Sentry. |
samuel40791765
force-pushed
the
mysql-8.3
branch
from
67a10b3
to
66e303f
Compare
samuel40791765
force-pushed
the
mysql-8.3
branch
2 times, most recently
from
534c463
to
fbe350b
Compare
samuel40791765
force-pushed
the
mysql-8.3
branch
3 times, most recently
from
ae8625a
to
17a9661
Compare
| @@ -45,7 +46,7 @@ function mysql_patch_reminder() { | |||
| } | |||
|
|
|||
| function mysql_build() { | |||
| cmake ${MYSQL_SRC_FOLDER} -GNinja -DWITH_BOOST=${BOOST_INSTALL_FOLDER} -DWITH_SSL=${AWS_LC_INSTALL_FOLDER} "-B${MYSQL_BUILD_FOLDER}" -DCMAKE_BUILD_TYPE=RelWithDebInfo | |||
| cmake ${MYSQL_SRC_FOLDER} -GNinja -DWITH_SSL=system -DCMAKE_PREFIX_PATH=${AWS_LC_INSTALL_FOLDER} "-B${MYSQL_BUILD_FOLDER}" -DCMAKE_BUILD_TYPE=RelWithDebInfo | |||
| time ninja -C ${MYSQL_BUILD_FOLDER} | |||
| ls -R ${MYSQL_BUILD_FOLDER} | |||
| } | |||
There was a problem hiding this comment.
can we add a ldd ... | grep $AWS_LC_INSTALL_FOLDER/lib/libssl.so check to assert that mysql is properly built against AWS_LC?
There was a problem hiding this comment.
Sure, just added
justsmth
previously approved these changes
Apr 15, 2024
samuel40791765
force-pushed
the
mysql-8.3
branch
from
27c98e3
to
28bac90
Compare
samuel40791765
force-pushed
the
mysql-8.3
branch
from
28bac90
to
3ee9a8c
Compare
justsmth
approved these changes
Apr 15, 2024
WillChilds-Klein
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Resolves
V1073444663Description of changes:
MySQL 8.2/8.3 changed some of the build behavior with OpenSSL. According to the documentation,
-DWITH_SSL={path_name}is a viable option, but it only seems to work with Visual Studio and MacOS due to the usage of${CMAKE_CFG_INTDIR}.${CMAKE_CFG_INTDIR}is undefined on single build configs like regular Make and Ninja, so our build fails when using the option.Another option was documented in the link above:
Using this gets around our issues. This PR is still pending the merge of #1496 and #1504 before the CI can pass.
Call-outs:
N/A
Testing:
CI update
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.