-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PQ README #1932
Merged
Merged
PQ README #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1932 +/- ##
==========================================
+ Coverage 78.66% 78.68% +0.01%
==========================================
Files 585 585
Lines 100849 100849
Branches 14297 14297
==========================================
+ Hits 79336 79349 +13
+ Misses 20876 20865 -11
+ Partials 637 635 -2 ☔ View full report in Codecov by Sentry. |
geedo0
reviewed
Oct 18, 2024
geedo0
approved these changes
Oct 18, 2024
darylmartin100
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
To better communicate our current support for PQ algorithms in AWS-LC and their integrations, we add the first draft of a PQ README documentation. This documentation is aimed to help users of AWS-LC understand which PQ algorithms are provided, give more details into their security levels, key/signature/ciphertext sizes.
This is a living document that will continue to be updated over time. If there is any feedback/additions/amendments please contribute them directly either as a review suggestion, so there is an explicit change to capture.
Call-outs:
crypto/fipsmodule/PQREADME.md
the correct location for this documentation? I selected this location to be consistent with similar documentation (https://github.com/aws/aws-lc/blob/main/crypto/fipsmodule/FIPS.md)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.