Remove retries on PCT failure in EC and RSA key generation. (#1938) #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FIPS review: The module should enter an error state if PCT fails in EC or RSA key generation, so there should be no retries and it aborts. This is to avoid that other threads would continue to use the module. (cherry picked from commit 90d2a34)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fips-2024-09-27 #1944 +/- ##
===================================================
- Coverage 78.59% 78.58% -0.01%
===================================================
Files 585 585
Lines 100520 100509 -11
Branches 14256 14254 -2
===================================================
- Hits 79001 78987 -14
- Misses 20881 20888 +7
+ Partials 638 634 -4 ☔ View full report in Codecov by Sentry. |
skmcgrail
approved these changes
Oct 23, 2024
justsmth
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #CryptoAlg-2756
Description of changes:
FIPS review: The module should enter an error state if PCT fails in EC or RSA key generation, so there should be no retries and it aborts. This is to avoid that other threads would continue to use the module.
(cherry picked from commit 90d2a34 on main, PR #1938)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.