Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mwaa-local-env): adding in --remove-orphans to docker-compose co… #321

Open
wants to merge 1 commit into
base: v2.6.3
Choose a base branch
from

Conversation

brbrown25
Copy link

@brbrown25 brbrown25 commented Nov 7, 2023

…mmands.

Description of changes: Adding in the remove-orphans command which is useful when experimenting with various changes such as adding and removing containers. from the docs Remove containers for services not defined in the Compose file. So if you're experimenting with adding and removing things you end up with dangling containers that eat up space if you don't add this flag. By adding this flag you remove warnings like

WARN[0000] Found orphan containers ([aws-mwaa-local-runner-2_6-local-runner-1]) for this project. If you removed or renamed this service in your compose file, you can run this command with the --remove-orphans flag to clean it up.

In my test of adding in the flag and running the start command after tweaking the name of service I didn't see any negative impacts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@o-nikolas
Copy link
Contributor

Can you add more description to this PR? What goal are you trying to achieve, how did you test it, are there any drawbacks, etc

@brbrown25
Copy link
Author

Can you add more description to this PR? What goal are you trying to achieve, how did you test it, are there any drawbacks, etc

yeah I can do that!

Copy link
Contributor

@mayushko26 mayushko26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but to keep it consistent we should also port this change to the other versions as well as a followup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants