fix: cryptography for fernet key gen #372
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khannz
changed the title
maanijou
reviewed
Apr 26, 2024
| pushd /python_install/$python_file | ||
| ./configure | ||
| make install -j $(nproc) # use -j to set the cores for the build | ||
| popd | ||
|
|
||
| # Upgrade pip | ||
| pip3 install $PIP_OPTION --upgrade 'pip<23' | ||
| pip3 install $PIP_OPTION --upgrade 'pip<23' cryptography |
There was a problem hiding this comment.
Minor: This can be a completely new line like this:
# Needed for generating fernet key for local runner
pip3 install --constraint /constraints.txt cryptography
|
+1 for the change. This also exist on MWAA 2.7.2 and probably some other versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #350
Description of changes: package 'cryptography' was installed for system python (which is 3.9) via apt. Since during build we replace system python with 3.11(.7) and later use it as primary one, it is required to install package
cryptographyvia pip withrootpermissions to be available system-wide.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.