chore: Bump pyyaml to version 6, revert pyyaml pins #5573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moelasmar
approved these changes
Jul 19, 2023
mndeveci
approved these changes
Jul 19, 2023
hawflau
reviewed
Jul 20, 2023
| @@ -7,7 +7,7 @@ Flask<2.3 | |||
| boto3>=1.26.109,==1.* | |||
| jmespath~=1.0.1 | |||
| ruamel_yaml~=0.17.32 | |||
| PyYAML>=5.4.1,==5.* | |||
| PyYAML>=6.0.1 | |||
There was a problem hiding this comment.
Nit: Should be do ~=6.0,>=6.0.1?
This will get at least 6.0.1 but won't do major version bump expectedly
realFranco
reviewed
Jul 20, 2023
| @@ -695,17 +704,12 @@ sarif-om==1.0.4 \ | |||
| --hash=sha256:539ef47a662329b1c8502388ad92457425e95dc0aaaf995fe46f4984c4771911 \ | |||
| --hash=sha256:cd5f416b3083e00d402a92e449a7ff67af46f11241073eea0461802a3b5aef98 | |||
| # via cfn-lint | |||
| serverlessrepo==0.1.10 \ | |||
There was a problem hiding this comment.
Hello, thank you for your contribution.
Some days ago, I was thinking:
- "why
aws-sam-cliis utilizingserverlessrepoconsidering the current status (only-read | public archive)?"
I have some questions now:
- How do you make sure that the package
serverlessrepois not been in use?; - Is there any other package with this same behaviour? (unused).
Seems to me that another non-used package soon or later "could" lead to another breaking. 👋
There was a problem hiding this comment.
Hi @realFranco, the serverlessrepo package was in fact being used by the sam publish command. We brought it in to be vendored by us yesterday #5572. All other dependencies are being used.
There was a problem hiding this comment.
Nice, thank you for the clarification.
bkahloon
pushed a commit
to bkahloon/amazon-emr-on-eks-custom-image-cli
that referenced
this pull request
Sep 21, 2023
**py** vulnerability resolved via the fix mentioned in [this Dependabot fix](https://github.com/awslabs/amazon-emr-on-eks-custom-image-cli/security/dependabot/1), which is to update package pytest to `7.2.0` and remove dependency on `py` package. Which subsequently required updating PyYaml to `~=6.0,>=6.0.1` (based on [this aws-sam-cli fix](aws/aws-sam-cli#5573))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
#5543
Why is this change necessary?
Fix an issue where there are multiple dependency conflicts causing issues with pip install.
How does it address the issue?
We've removed our dependency on
serverlessreposo that we can bumppyyaml.What side effects does this change have?
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.