Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump click from 8.1.3 to 8.1.6 in /requirements #5575

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 20, 2023

Bumps click from 8.1.3 to 8.1.6.

Release notes

Sourced from click's releases.

8.1.6

This is a fix release for the 8.1.x feature branch. If you were having issues with type checking tools like pyright or mypy not accepting uses of Click's decorators, this should fix that.

8.1.5

This is a fix release for the 8.1.x feature branch. This fixes an issue with decorator type annotations that caused type checkers to fail for valid code. There are no runtime behavior changes.

8.1.4

This is a fix release for the 8.1.x feature branch.

Changelog

Sourced from click's changelog.

Version 8.1.6

Released 2023-07-18

  • Fix an issue with type hints for @click.group(). :issue:2558

Version 8.1.5

Released 2023-07-13

  • Fix an issue with type hints for @click.command(), @click.option(), and other decorators. Introduce typing tests. :issue:2558

Version 8.1.4

Released 2023-07-06

  • Replace all typing.Dict occurrences to typing.MutableMapping for parameter hints. :issue:2255
  • Improve type hinting for decorators and give all generic types parameters. :issue:2398
  • Fix return value and type signature of shell_completion.add_completion_class function. :pr:2421
  • Bash version detection doesn't fail on Windows. :issue:2461
  • Completion works if there is a dot (.) in the program name. :issue:2166
  • Improve type annotations for pyright type checker. :issue:2268
  • Improve responsiveness of click.clear(). :issue:2284
  • Improve command name detection when using Shiv or PEX. :issue:2332
  • Avoid showing empty lines if command help text is empty. :issue:2368
  • ZSH completion script works when loaded from fpath. :issue:2344.
  • EOFError and KeyboardInterrupt tracebacks are not suppressed when standalone_mode is disabled. :issue:2380
  • @group.command does not fail if the group was created with a custom command_class. :issue:2416
  • multiple=True is allowed for flag options again and does not require setting default=(). :issue:2246, 2292, 2295
  • Make the decorators returned by @argument() and @option() reusable when the cls parameter is used. :issue:2294
  • Don't fail when writing filenames to streams with strict errors. Replace invalid bytes with the replacement character (). :issue:2395
  • Remove unnecessary attempt to detect MSYS2 environment. :issue:2355
  • Remove outdated and unnecessary detection of App Engine environment. :pr:2554
  • echo() does not fail when no streams are attached, such as with pythonw on Windows. :issue:2415
  • Argument with expose_value=False do not cause completion to fail. :issue:2336
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [click](https://github.com/pallets/click) from 8.1.3 to 8.1.6.
- [Release notes](https://github.com/pallets/click/releases)
- [Changelog](https://github.com/pallets/click/blob/8.1.6/CHANGES.rst)
- [Commits](pallets/click@8.1.3...8.1.6)

---
updated-dependencies:
- dependency-name: click
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 20, 2023 08:44
@dependabot dependabot bot requested review from sriram-mv and mildaniel July 20, 2023 08:44
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jul 20, 2023
@@ -1,7 +1,7 @@
chevron~=0.12
# 8.1.4 of Click has an issue with the typing breaking the linter - https://github.com/pallets/click/issues/2558
# Allow click to be greater than 8.1.4 when https://github.com/pallets/click/pull/2565 is released.
click~=8.0,<8.1.4
click~=8.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this PR still picked up 8.1.5 for the Windows 3.9 make pr job.

Requirement already satisfied: click~=8.1 in c:\hostedtoolcache\windows\python\3.9.13\x64\lib\site-packages (from aws-sam-cli==1.92.0) (8.1.5)

Thoughts on changing this to

Suggested change
click~=8.1
click~=8.1.6

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it fixed now since Windows jobs are succeeding?

Copy link
Contributor

@mndeveci mndeveci Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But weird enough, windows reproducible picked existing version (8.1.3) 🤔
https://github.com/aws/aws-sam-cli/actions/runs/5761609268/job/15619767697?pr=5575#step:4:595

@mildaniel
Copy link
Contributor

Closing in favour of #5812

@mildaniel mildaniel closed this Aug 23, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 23, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/requirements/develop/click-8.1.6 branch August 23, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file pr/internal python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants