Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove resolve-image-repos error message from the commands it is not supported #5596

Merged
merged 2 commits into from
Jul 22, 2023

Conversation

mndeveci
Copy link
Contributor

Which issue(s) does this change fix?

#5424

Why is this change necessary?

Error messages for sam package and sam sync includes possible option --resolve-image-repos which is not supported for these commands.

How does it address the issue?

By removing it from error messages for these commands.

What side effects does this change have?

N/A

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mndeveci mndeveci requested a review from a team as a code owner July 21, 2023 22:56
@github-actions github-actions bot added pr/internal area/package sam package command area/deploy sam deploy command area/sync sam sync command and removed pr/internal labels Jul 21, 2023
Copy link
Contributor

@hnnasit hnnasit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mndeveci mndeveci enabled auto-merge July 22, 2023 00:16
@mndeveci mndeveci added this pull request to the merge queue Jul 22, 2023
Merged via the queue into aws:develop with commit 3cee812 Jul 22, 2023
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/deploy sam deploy command area/package sam package command area/sync sam sync command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants