Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update generation logic #5604

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

Leo10Gama
Copy link
Member

Why is this change necessary?

Previously, generation logic was not working due to the file handling the generation being named identically to the folder, causing import errors. In addition, some custom parameter types were failing in the newly-implemented checks for type names.

How does it address the issue?

The file housing the generation logic has been renamed to make_schema.py. A new constant has been added to map the custom-typed parameters to their JSON schema representation type. This includes parameter_overrides, which can be provided as an array or a string.

What side effects does this change have?

Some of the types in the schema have been updated to better reflect their actual typing.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 24, 2023 21:44
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 24, 2023
@Leo10Gama Leo10Gama changed the title Fix generation logic fix: Update generation logic Jul 24, 2023
schema/make_schema.py Outdated Show resolved Hide resolved
@lucashuy lucashuy merged commit 1e7fcdd into aws:feat/json-schema Jul 25, 2023
73 checks passed
@Leo10Gama Leo10Gama deleted the fix-tests branch July 25, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants