feat: Added APIGW V2 Authorizer property mapping #5623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mildaniel
reviewed
Jul 26, 2023
| @@ -941,6 +943,44 @@ def setUp(self) -> None: | |||
| "Metadata": {"SamResourceId": f"aws_apigatewayv2_integration.{self.apigwv2_integration_name}"}, | |||
| } | |||
|
|
|||
| self.tf_apigwv2_authorizer_common_attributes: dict = { | |||
There was a problem hiding this comment.
We shoudl add this authorizer to the self.tf_json_with_root_module_only list below for the transformation to be tested.
mildaniel
reviewed
Jul 27, 2023
| }, | ||
| } | ||
|
|
||
| self.maxDiff = None |
There was a problem hiding this comment.
Why do we need to set this?
There was a problem hiding this comment.
Whoops, left over from debugging, will remove
mildaniel
approved these changes
Jul 27, 2023
…to map_v2_auth_resources
|
Superseded by #5625 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
None.
Why is this change necessary?
Adds the property mappings between the Terraform and Cloudformation V2 Authorizer resources.
How does it address the issue?
Uses the existing mapping logic to match the Terraform properties to their equivalent Cloudformation counter parts.
What side effects does this change have?
None.
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.