Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InvalidSamDocumentException to a subclass of UserException #5643

Closed
wants to merge 2 commits into from

Conversation

hawflau
Copy link
Contributor

@hawflau hawflau commented Jul 28, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

InvalidSamDocumentException not being a UserException cause sam build to throw a stack trace when there's any invalid template issue.

How does it address the issue?

Make InvalidSamDocumentException a subclass of UserException

What side effects does this change have?

No

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added pr/internal area/validate sam validate command labels Jul 28, 2023
@hawflau hawflau closed this Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/validate sam validate command pr/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant