Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Repair failing config integration test #5653

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

Leo10Gama
Copy link
Member

Why is this change necessary?

One of the integration tests for sam deploy was failing when being passed an invalid config file. This is due to the fact that, when given an invalid config file, it throws a different error. This change has been better reflected in this test.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner July 31, 2023 17:37
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Jul 31, 2023
@lucashuy lucashuy enabled auto-merge July 31, 2023 18:12
@lucashuy lucashuy added this pull request to the merge queue Jul 31, 2023
Merged via the queue into aws:develop with commit 71eed64 Jul 31, 2023
75 checks passed
@Leo10Gama Leo10Gama deleted the fix-config-integ branch July 31, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants