Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add schema generation to GitHub Actions #5683

Merged
merged 4 commits into from
Aug 3, 2023

Conversation

Leo10Gama
Copy link
Member

Why is this change necessary?

With the new schema generation logic, we want to ensure that the script runs in such a way as to keep the schema up to date with the current changes.

How does it address the issue?

A new GitHub Actions workflow has been created to run the schema generation script once per weekday, check if the schema has been altered in any way, and if it has, open a PR to make the necessary changes.

What side effects does this change have?

At least once every weekday, if the generated schema is changed in any way, a PR will be raised to update it.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Leo10Gama Leo10Gama requested a review from a team as a code owner August 2, 2023 17:35
@github-actions github-actions bot added pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. labels Aug 2, 2023
.github/workflows/build.yml Outdated Show resolved Hide resolved
@lucashuy lucashuy merged commit 118e174 into aws:feat/json-schema Aug 3, 2023
74 checks passed
@Leo10Gama Leo10Gama deleted the schema-actions branch August 3, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/external stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants