-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Delete stacks in REVIEW_IN_PROGRESS #5687
Conversation
change_sets = change_sets.get("Summaries", []) | ||
|
||
if len(change_sets) > 0: | ||
change_set = change_sets[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the change set in index 0 always the latest, do we need to add any sorting to the service call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double checked, the change sets are sorted in ascending order if there are more than one. However, for the purposes of this PR we are going to delete the first change set and the template associated with it.
The others will be left to the user as we'll want to make sure the stack is deleted so that the customer is unblocked.
I'll make a change to add a log message to let them know that there may be lingering artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me, I left some minor comment and a question.
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * Install deps into a virtual env --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * Install deps into a virtual env * Fix Windows test failure --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install * Fix conflict --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]>
* chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf9. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * fix: supporting nested apis for v1 method, integration, and integration response resources. (#5712) * Install deps into a virtual env * Fix Windows test failure * Fix install * Fix install * Fix install * Fix install * Fix conflict * Format files * feat: updating app templates repo hash with (590b5e90d681c504213e6c35d56c0d63d9401c0b) (#5668) Co-authored-by: GitHub Action <[email protected]> * use get_sam_command to get the base sam command in regression pacakge test cases. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Daniel Mil <[email protected]> Co-authored-by: Daniel Mil <[email protected]>
* Add Windows config (#5657) * Binary canaries (#5658) * Add Windows config * Fix formatting * Binary canaries (#5659) * Add Windows config * Fix formatting * Update config * Test/binary canaries (#5660) * Add Windows config * Fix formatting * Update config * test * Test/binary canaries (#5661) * Add Windows config * Fix formatting * Update config * test * Update config * Test/binary canaries (#5662) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Test/binary canaries (#5663) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Test/binary canaries (#5664) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Test/binary canaries (#5667) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Test/binary canaries (#5669) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Test/binary canaries (#5682) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Test/binary canaries (#5684) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Test/binary canaries (#5685) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Test/binary canaries (#5686) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Test/binary canaries (#5688) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5689) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5690) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5691) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5692) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5693) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5694) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5695) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5696) * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * Update config * Update config * Add linux config * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Test/binary canaries (#5699) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5700) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5702) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5703) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5704) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5705) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5706) * test with msi * fix path * set quite option * wait for installation to finish and refresh env * use Start-Process * only install dev deps * update path after installation * run pip install with SAM_CLI_DEV * check sam with powershell * set path before starting pytest * add shell=True for all subprocess calls * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Test/binary canaries (#5707) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Test/binary canaries (#5709) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Test/binary canaries (#5710) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Test/binary canaries (#5711) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Revert "Test/binary canaries (#5706)" This reverts commit 8a9e0c92f2f0f250316babc36312d523c23dced4. --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Test/binary canaries (#5717) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Revert "Test/binary canaries (#5706)" This reverts commit 8a9e0c92f2f0f250316babc36312d523c23dced4. * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Test/binary canaries (#5718) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * Add Windows config * Fix formatting * Update config * test * Update config * Update config * Update config * Update config * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * Update config * Update config * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add linux config * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * Update install links * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * Update linux config * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * Update Windows config * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Update Windows config * Revert "Test/binary canaries (#5706)" This reverts commit 8a9e0c92f2f0f250316babc36312d523c23dced4. * Update Windows config * Update Windows config --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * test: AppVeyor Jobs Running Against Nightly Binaries * Install deps into a virtual env * Binary canary config (#5720) * chore: Update CFN Lint version to support python 3.11 (#5651) * Update CFN Lint version to support python 3.11 * Run make update-reproducible-reqs --------- Co-authored-by: Mohamed Elasmar <[email protected]> * fix: Require file label to run before maintainers (#5656) * Require file label to run before maintainers * Run maintainer label job even if previous job fails * chore: update aws_lambda_builders to 1.36.0 (#5655) Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> * fix(invoke): Write in UTF-8 string instead of bytes (#5642) * Revert "fix: Revert UTF-8 fixes #5485 and #5427 (#5512)" This reverts commit 36f8bf970df7a8072eef58ca76405c40e1cc1c90. * Enforce utf8 on stdout/stderr/logfile --------- Co-authored-by: Jacob Fuss <[email protected]> * chore(deps): bump cryptography from 41.0.2 to 41.0.3 in /requirements (#5675) Bumps [cryptography](https://github.com/pyca/cryptography) from 41.0.2 to 41.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](https://github.com/pyca/cryptography/compare/41.0.2...41.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix(test): Force reading file with utf8 in tests for windows (#5679) Co-authored-by: Jacob Fuss <[email protected]> * fix(test): Increase max execution time for timeout tests (#5680) Co-authored-by: Jacob Fuss <[email protected]> * chore: auto update reproducible requirements when there is a dependency change (#5677) * chore: add reproducible gha * format * formatting v2 * format v3 * use win make target * update windows job * update win paths * why windows why * remove if stmt for now * test with direct paths * update windows paths again * bring back activate * add dummy win file and push changes * update base.txt for testing * Update reproducibles * run jobs sequentially * print changed flag * check changes again * run git status before moving forward * refresh index before checking any changed files * Update reproducibles * commit or skip * Update reproducibles * rerun build & pyinstaller jobs once update reproducible finishes * add more details to commit message * nuke all reproducibles to trigger the CI * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * change lb version for testing * update permissions and limit only for aws/aws-sam-cli * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * update other jobs as well * run without file filter * Update reproducibles: update-reproducible-linux-reqs * Update reproducibles: update-reproducible-mac-reqs * Update reproducibles: update-reproducible-win-reqs * put the file filter back --------- Co-authored-by: GitHub Action <[email protected]> * fix: Repair failing integration test (#5698) * Fix failing integration test * Be more specific with error message --------- Co-authored-by: Leonardo Gama <[email protected]> * fix: link the API gateway resource parent to either rest api or another gateway resource (#5697) * fix: Delete stacks in REVIEW_IN_PROGRESS (#5687) * Added functionality to delete stacks in REVIEW_IN_PROGRESS * Removed setting output to variable * Addressed comments * Added disclaimer to clean up lingering resources if there are more than one change set * test: AppVeyor Jobs Running Against Nightly Binaries * Install deps into a virtual env --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Connor Kirkpatrick <[email protected]> Co-authored-by: Mohamed Elasmar <[email protected]> Co-authored-by: Lucas <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: Jacob Fuss <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mehmet Nuri Deveci <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> Co-authored-by: Leonardo Gama <[email protected]> * Fix Windows test failure * …
Which issue(s) does this change fix?
#5533
Why is this change necessary?
Stacks in
REVIEW_IN_PROGRESS
were not being deleted since the stack does not yet have a template. This meant that any stacks stuck in this state, were not delete-able with SAM CLI since we need that stack to find the file in S3 to delete.How does it address the issue?
Change sets contain the stack we can use to delete template files. This change uses the change set's template file to find the one in the S3 bucket to delete.
What side effects does this change have?
The helper method to return a template response, now returns the template body as a string (previous was returning a dictionary).
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make pr
passesmake update-reproducible-reqs
if dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.