Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Windows reproducibles and CI/CD python to 3.11 from 3.8 for msi installer #6160

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Oct 26, 2023

Which issue(s) does this change fix?

N/A

Why is this change necessary?

This PR updates the windows reproducible dependencies by generating them using python3.11 and updates the windows-binary appveyor config to use python3.11. This allows the installer to be more current with the python version and keep the dependencies in better state.

How does it address the issue?

Described above

What side effects does this change have?

No side effects

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…6158)

* Update windows appveyor config to test on artifact

* Update URL used to download artifact
… for msi installer (#6159)

* Update windows appveyor config to test on artifact

* Update URL used to download artifact

* Update windows preducible dependencies to use py311 and update appveyor/GH action configs
@hnnasit hnnasit marked this pull request as ready for review October 26, 2023 21:39
@hnnasit hnnasit requested a review from a team as a code owner October 26, 2023 21:39
@hnnasit hnnasit added this pull request to the merge queue Oct 26, 2023
Merged via the queue into develop with commit 6636c1f Oct 27, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants