Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin down watchdog to 4.0.2 to fix sam sync --watch issues #7611

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

hnnasit
Copy link
Contributor

@hnnasit hnnasit commented Oct 28, 2024

Which issue(s) does this change fix?

#7581

Why is this change necessary?

watchdog 5.0.3 introduced some breaking changes for python versions > 3.8. This PR pins down the version to 3.8 which is the lowest python version currently being used.

How does it address the issue?

Fix the sam sync watch issues.

What side effects does this change have?

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hnnasit hnnasit requested a review from a team as a code owner October 28, 2024 20:24
@hnnasit hnnasit closed this Oct 28, 2024
@hnnasit hnnasit reopened this Oct 28, 2024
@hnnasit hnnasit closed this Oct 28, 2024
@hnnasit hnnasit reopened this Oct 28, 2024
@hnnasit hnnasit closed this Oct 28, 2024
@hnnasit hnnasit reopened this Oct 28, 2024
@hnnasit hnnasit added this pull request to the merge queue Oct 28, 2024
Merged via the queue into develop with commit c515b9e Oct 28, 2024
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants