Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't overwrite defaulted config #6166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

batzz-00
Copy link

@batzz-00 batzz-00 commented Jun 5, 2024

Issue

Issue number, if available, prefixed with "#"

Description

What does this implement/fix? Explain your changes.
The documentation for the credentials option would lead you to think an explicit undefined or omitting the option would use the default credential provider, the current implementation only works for the latter scenario. Explicitly passing undefined uses the default provider in v2.

In the scenario that a user provides credentials: undefined in the config object, because it is spread at the end of the object, the defaulted properties are overwritten

Testing

How was this change tested?

Additional context

Add any other context about the PR here.

Checklist

  • If you wrote E2E tests, are they resilient to concurrent I/O?
  • If adding new public functions, did you add the @public tag and enable doc generation on the package?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@batzz-00 batzz-00 requested a review from a team as a code owner June 5, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant