Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codegen): checkstyle issue in DocumentBareBonesClientGenerator #6455

Merged
merged 2 commits into from
Sep 10, 2024

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Sep 10, 2024

Issue

This was missed in #6449 as the codegen-ci was not run, likely to some issue with one of the paths configs #6439

Description

Fix the checkstyle issue to unblock #6453
The investigation for why codegen-ci was not run will be done as a follow-up.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr
Copy link
Member Author

trivikr commented Sep 10, 2024

Verified that codegen-ci was run for the commit as it contained changes in codegen/**.

@trivikr
Copy link
Member Author

trivikr commented Sep 10, 2024

The new commit b79264d (#6455) did not have changes in codegen.

But the codegen-ci was still run for it. Probably because the previous commit had changes in codegen.

@trivikr trivikr marked this pull request as ready for review September 10, 2024 19:59
@trivikr trivikr requested a review from a team as a code owner September 10, 2024 19:59
@trivikr
Copy link
Member Author

trivikr commented Sep 10, 2024

For future reference: the only reason I can think of why codegen-ci was not run for #6449, if either because commit which contained changes in codegen folder was pushed as a part of the group.

UPDATE: when I posted this PR with new commits as part of a collection, the codegen-ci was run #6457. That makes me believe the issue in #6449 happened because of some intermediate state, like force-push which contained the changes in codegen-ci paths.

@trivikr trivikr merged commit c3d86a6 into aws:main Sep 10, 2024
6 of 8 checks passed
@trivikr trivikr deleted the fix-codegen-checkstyle branch September 10, 2024 20:14
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants