Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add client config for userAgentAppId #6524

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

siddsriv
Copy link
Contributor

@siddsriv siddsriv commented Sep 26, 2024

Issue

Internal JS-5173

Description

Adds a client config field for userAgentAppId

Testing

Unit tests:

  • util-user-agent-browser
Location: /local/home/sidddsri/workspace/aws-sdk-js-v3/packages/util-user-agent-browser
.
 PASS  src/index.native.spec.ts
 PASS  src/index.spec.ts

Test Suites: 2 passed, 2 total
Tests:       5 passed, 5 total
Snapshots:   0 total
Time:        4.485 s
  • middleware-user-agent
 PASS  src/user-agent-middleware.spec.ts
  userAgentMiddleware
    ✓ should include appId in user agent when provided (1 ms)
    ✓ should include long appId in user agent when provided (1 ms)
  • Client config option is generated:
.
.
/**
   * The AWS region to which this client will send requests
   */
  region?: string | __Provider<string>;

  /**
   * The application ID used to identify the application.
   */
  userAgentAppId?: string | __Provider<string>;
.
.
.
.
    useFipsEndpoint: config?.useFipsEndpoint ?? loadNodeConfig(NODE_USE_FIPS_ENDPOINT_CONFIG_OPTIONS),
    userAgentAppId: config?.userAgentAppId ?? loadNodeConfig(NODE_APP_ID_CONFIG_OPTIONS),
.
.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@siddsriv siddsriv requested a review from a team as a code owner September 26, 2024 16:35
@siddsriv siddsriv marked this pull request as draft September 26, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant