update DynamoDBEntryConversion.TryFromEntry to make it more readable

aws · Jan 17, 2023 · 18ef731 · 18ef731
1 parent 338c7d3
commit 18ef731
Showing 1 changed file with 10 additions and 7 deletions.
diff --git a/sdk/src/Services/DynamoDBv2/Custom/Conversion/DynamoDBEntryConversion.cs b/sdk/src/Services/DynamoDBv2/Custom/Conversion/DynamoDBEntryConversion.cs
@@ -571,14 +571,17 @@ public bool TryFromEntry(DynamoDBEntry entry, Type targetType, out object value)
 
             var d = entry as Document;
             if (d != null && TryFrom(d, targetType, out value))
-                return true;
-
-            value = null;
-
-            var n = entry as DynamoDBNull;
+                return true;
+
+            var n = entry as DynamoDBNull;
             if (n != null)
-                return true;
-
+            {
+                value = null;
+                return true;
+            }
+
+            // Could not convert entry to a known type, setting value to null as it's an out parameter
+            value = null;
             return false;
         }