Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update CloudFrontKeyValueStore client to use AWS4aSignerCRTWrapper #3144

Merged

Conversation

muhammad-othman
Copy link
Member

@muhammad-othman muhammad-othman commented Jan 12, 2024

Description

CloudFrontKeyValueStore latest version requires SigV4a, however our code is still using SigV4 because C2J still has Sigv4 as the SignatureVersion.
This PR forces CloudFrontKeyValueStore client to use AWS4aSignerCRTWrapper till we get SRA identity and auth in place.

Motivation and Context

A customer raised this issue #3143 when using CloudFrontKeyValueStore

Testing

  • Tested the same code that was included in the issue and ListKeysAsync method returned the keys and didn't throw an exception.
  • Did a full dry run

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

Copy link
Member

@normj normj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending internal checks pass.

@muhammad-othman muhammad-othman force-pushed the cloudfront-keyvaluestore-sigv4-bug-fix branch from f273701 to 7060594 Compare January 12, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DotNet Credential should be scoped to a valid region when using CloudFront KeyValueStore
4 participants