fix: Added logic to marshall NoncurrentVersionExpiration.NewerNoncurrentVersions in PutLifecycleConfigurationRequestMarshaller. #3581
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entVersions in PutLifecycleConfigurationRequestMarshaller.
ashishdhingra
force-pushed
the
user/ashdhin/S3-PutLifecycleConfiguration-Issue3580
branch
from
a25ea33 to
7770c31
Compare
|
Can we please get this merged ? |
normj
approved these changes
Dec 19, 2024
gcbeattyAWS
approved these changes
Dec 19, 2024
muhammad-othman
approved these changes
Dec 19, 2024
boblodgett
deleted the
user/ashdhin/S3-PutLifecycleConfiguration-Issue3580
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logic to marshall
NoncurrentVersionExpiration.NewerNoncurrentVersionsinPutLifecycleConfigurationRequestMarshaller.Motivation and Context
Issue #3580
Testing
Modified integration test in sdk/test/Services/S3/IntegrationTests/LifecycleTests.cs to set
NoncurrentVersionExpiration.NewerNoncurrentVersionsinPutLifecycleConfigurationRequest, submit theLifecycleConfigurationviaAmazons3Client.PutLifecycleConfiguration()and validate the same when retrieved usingAmazons3Client.GetLifecycleConfiguration().Catapult dry-run completed successfully.
Screenshots (if appropriate)
Types of changes
Checklist
License