-
Notifications
You must be signed in to change notification settings - Fork 863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge PR from feature branch into v4-development branch for System.Text.Json serialization #3612
base: v4-development
Are you sure you want to change the base?
Conversation
* Serialization changes for System Text Json
* Update unmarshallers to use system text json. Includes Core and generator changes
@@ -83,9 +83,6 @@ | |||
<PackageReference Include="Microsoft.Bcl.AsyncInterfaces" Version="8.0.0" /> | |||
<PackageReference Include="System.Buffers" Version="4.5.1" /> | |||
<PackageReference Include="System.Memory" Version="4.5.5" /> | |||
<!-- Powershell 7+ already has a preloaded version of system text json which is older than the version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem correct. Perhaps your merge picked the wrong files to keep?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup must've gotten lost in the rebase. will add both back
sdk/src/Core/AWSConfigs.cs
Outdated
|
||
#endregion | ||
|
||
#region SDK Cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation looks off here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, will fix in next rev.
Description
**Everything in this PR has been reviewed except for the DevConfig which I added. **
This is just the PR that includes all the changes to merge into the v4-development branch PLUS two additional changes I had to make since additional PRs were merged into the v4-development branch (#3609)
4a158ba - I updated the custom SparseJsonrequest/Response marshallers to use system text json
3839ebb - This commit contains the generated changes for the protocol test related shapes (updated to use system text json)
I purposely didn't squash all the commits because each commit is a PR that has been approved and I wanted to keep that history.
Motivation and Context
Testing
Dry Run PASSED
Protocol Tests pass
Screenshots (if appropriate)
Types of changes
Checklist
License