-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(amazonq): default optin project context for internal users #5019
Merged
Will-ShaoHua
merged 12 commits into
aws:main
from
Will-ShaoHua:enable-workspace-default
Nov 13, 2024
Merged
config(amazonq): default optin project context for internal users #5019
Will-ShaoHua
merged 12 commits into
aws:main
from
Will-ShaoHua:enable-workspace-default
Nov 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
changed the title
default optin project context for internal users
config(amazonq): default optin project context for internal users
Oct 28, 2024
leigaol
reviewed
Nov 12, 2024
@@ -30,6 +35,12 @@ class AmazonQStartupActivity : ProjectActivity { | |||
override suspend fun execute(project: Project) { | |||
if (ApplicationManager.getApplication().isUnitTestMode) return | |||
|
|||
ToolkitConnectionManager.getInstance(project).activeConnectionForFeature(QConnection.getInstance())?.let { | |||
if (it is AwsBearerTokenConnection && isInternalUser(it.startUrl)) { | |||
CodeWhispererSettings.getInstance().toggleProjectContextEnabled(true, passive = true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure this toggle only happens once
leigaol
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please manually test it E2E
samgst-amazon
approved these changes
Nov 13, 2024
manodnyab
reviewed
Nov 13, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/startup/AmazonQStartupActivity.kt
Outdated
Show resolved
Hide resolved
...nq/shared/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/QUtils.kt
Outdated
Show resolved
Hide resolved
dhasani23
pushed a commit
to ntarakad-aws/aws-toolkit-jetbrains
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aws/aws-toolkit-vscode#5856
Enable implicit @ workspace context for Amzn users
implicit workspace context denotes chat invocation without
@workspace
prefixexplicit workspace context denotes chat invocation with
@workspace
prefixLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.