PR comment fixes

- Simplify tests - Fix typos Signed-off-by: nkomonen-amazon <[email protected]>
aws · Nov 15, 2024 · 123e897 · 123e897
1 parent 7e89891
commit 123e897
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 22 deletions.
diff --git a/docs/telemetry.md b/docs/telemetry.md
@@ -170,7 +170,7 @@ function failsDependingOnInput(num: number) {
 
 ### Solution
 
-On class methods use the `@withTelemetryContext()` decorator add context to the execution. Depending on the args set, it provides features like emitting the result, or adding it's context to errors.
+On class methods, use the `@withTelemetryContext()` decorator to add context to the execution. Depending on the args set, it provides features like emitting the result, or adding it's context to errors.
 
 > NOTE: Decorators are currently only supported for methods and not functions
 

diff --git a/packages/core/src/test/shared/telemetry/spans.test.ts b/packages/core/src/test/shared/telemetry/spans.test.ts
@@ -642,37 +642,34 @@ describe('TelemetryTracer', function () {
             assert.throws(
                 () => inst.throwsError(),
                 (e) => {
-                    if (!(e instanceof ToolkitError)) {
-                        return false
-                    }
-                    const id = getErrorId(e)
-                    const message = e.message
-                    const cause = e.cause
-                    return id === 'TestThrows' && message === 'ctx: throwsError' && cause === arbitraryError
+                    return (
+                        e instanceof ToolkitError &&
+                        getErrorId(e) === 'TestThrows' &&
+                        e.message === 'ctx: throwsError' &&
+                        e.cause === arbitraryError
+                    )
                 }
             )
             assert.throws(
                 () => inst.throwsErrorButNoClass(),
                 (e) => {
-                    if (!(e instanceof ToolkitError)) {
-                        return false
-                    }
-                    const id = getErrorId(e)
-                    const message = e.message
-                    const cause = e.cause
-                    return id === 'Error' && message === 'ctx: throwsError' && cause === arbitraryError
+                    return (
+                        e instanceof ToolkitError &&
+                        getErrorId(e) === 'Error' &&
+                        e.message === 'ctx: throwsError' &&
+                        e.cause === arbitraryError
+                    )
                 }
             )
             await assert.rejects(
                 () => inst.throwsAsyncError(),
                 (e) => {
-                    if (!(e instanceof ToolkitError)) {
-                        return false
-                    }
-                    const id = getErrorId(e)
-                    const message = e.message
-                    const cause = e.cause
-                    return id === 'Error' && message === 'ctx: throwsError' && cause === arbitraryError
+                    return (
+                        e instanceof ToolkitError &&
+                        getErrorId(e) === 'Error' &&
+                        e.message === 'ctx: throwsError' &&
+                        e.cause === arbitraryError
+                    )
                 }
             )
         })