-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: remove package.json syncing #5629
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayemaxi
force-pushed
the
drop-tests
branch
2 times, most recently
from
September 18, 2024 21:47
f90fe2c
to
8ed6c4d
Compare
/runIntegrationTests |
justinmk3
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor bonus, it looks like this also helps move in the direction of having a single Tests (current file)
launch config, instead of 4+ configs for the same "current file" functionality.
hayemaxi
force-pushed
the
drop-tests
branch
3 times, most recently
from
September 24, 2024 15:39
82e4955
to
d0e7240
Compare
hayemaxi
force-pushed
the
drop-tests
branch
from
September 30, 2024 18:14
30e76d8
to
91ae88e
Compare
This was referenced Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to copy/sync package JSON contents from core -> subproject extensions on build and package.
Summary of changes:
amazonq/
,toolkit/
. Changes to extensions should be made only the respective file (except for icons).toolkit/
runs unit, e2e, and integ tests fromcore/
. It will also run any of its own tests (but those don't exist yet).amazonq/
. This was decided becauseamazonq/
is more likely to support web thantoolkit/
at this time. Also, it didn't seem possible to run the web tests fromcore/
like the other tests because it relies on webpack and a separate test runner.core/
Follow up work:
context.extension.packageJSON
instead..vscode/tasks.json
core/package.json
.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.