feat(dev): Stop code generation action #5675

tverney · 2024-09-26T16:39:43Z

Problem

Currently /dev don't support stop code generation. This PR introduces this functionality (watch the video below).

Solution

Mynah UI provides onStopChatResponse API which we can hook in the cancellation token provided on VS Code, sharing across an active session, aborting current progress.

Screen.Recording.2024-10-16.at.10.11.20.AM.mov

Notes:

RTS is already supporting the change on prod
codeGenerationId and uploadId are now being generated in FE
AppSec and pentest passed successfully
Telemetry is included in this PR and strings are reviewed/approved by Technical writer
This stop action is only introduced in /dev feature. This did not enable in any other product for this extension.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2024-09-26T16:39:56Z

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

…llation

…rence for stop code generation

… same session

…llation

…tance and abort the individual call

…cancellation should be in gen

github-actions · 2024-10-10T18:43:59Z

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

Add stop code gen telemetry

Problem: c8 was not given a reporter, therefore it defaulted to `text` which is the terminal. Solution: Set it to `lcov`, which is what we have been using previously. Note: More work may be needed on the .c8rc.json files. We might not need the one for core/ anymore. They may not be configured in the optimal way. Is it behaving how we want it to? ---  License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

…llation

…rence for stop code generation

… same session

…llation

…tance and abort the individual call

…cancellation should be in gen

tverney · 2024-10-22T19:39:22Z

We have already the security sign-off. Ready to be reviewed cc: @neilk-aws

packages/core/src/amazonq/webview/ui/connector.ts

packages/core/src/shared/telemetry/vscodeTelemetry.json

jpinkney-aws · 2024-10-23T14:41:53Z

packages/core/src/amazonq/webview/ui/followUps/handler.ts

@@ -46,6 +46,7 @@ export class FollowUpInteractionHandler {
        if (followUp.prompt !== undefined) {
            this.mynahUI.updateStore(tabID, {
                loadingChat: true,
+                cancelButtonWhenLoading: false,


Out of curiosity does this mean that every single update store will need this? Why isn't the default false and then its true when we want the cancel button (which I assume is the stop button) to show?

The change itself kind of scares me because we need to make sure its propagated everything and that everyone who makes changes to the updateStore knows why it exists

@jpinkney-aws Refer to the section on MynahUI https://github.com/aws/mynah-ui/blob/0f47cdf4dcaf2574ec118cdbe7c5cdb9339d4f6d/docs/DATAMODEL.md?plain=1#L38

"In addition to the spinner, if onStopChatResponse is attached globally through MynahUI main class constructor properties (see Constructor properties for details) and cancelButtonWhenLoading is not set to false specifically for that tab it will show the stop generating button too."

You can sync with @dogusata about this specifically.

If none of the functionalities are supporting onStopChatResponse why we have it attached to the mynahui instance? If some functions are using it, then this change makes sense. However the defaults can be changed for newly generated tabs. But i don't see any specific difference between giving true to the tabs which will using it or false to tabs which will not.

Additionally, giving the value during the tab generation is sufficient. Also, until send a new value, the previous value will remain.

@jpinkney-aws do we have a consensus about this specific ? Or do we need sync about it? I'm ok for now with @dogusata, no one its using it, I did safe check in all the places in this PR that we use the store.

So just to confirm - state of cancelButtonWhenLoading = false must be passed if onStopChatResponse was specified earlier, otherwise it defaults to true. If onStopChatResponse wasn't passed, then it doesn't matter.

If this is correct then the current implementation is fine IMO.

Exactly, that's the behaviour. If onStopChatResponse isn't passed, it defaults to false. Otherwise, need explicitly say false to not show it.

packages/core/src/amazonqFeatureDev/controllers/chat/controller.ts

packages/core/src/amazonqFeatureDev/session/sessionState.ts

…ton instead

telemetry(amazonq): use ui_click telemetry for stop code generate button instead

packages/core/src/amazonq/webview/ui/main.ts

tverney added 14 commits September 27, 2024 13:41

feat(amazonqFeatureDev): enable stop generating button

aaae062

feat(amazonqFeatureDev): include stop generation based on token cance…

c385dfc

…llation

fix(amazonqFeatureDev): move work on new task after session is closed

e05a87a

refactor(amazonqFeatureDev): include updated rts model

b013042

fix(amazonqFeatureDev): fix merge conflicts

709c0c5

fix(amazonqFeatureDev): include currentCodeGenerationId to track refe…

644dedd

…rence for stop code generation

refactor(amazonqFeatureDev): use else catch for return statement

ba2db03

refactor(amazonqFeatureDev): add logic for codeGenerationId

b791a2b

fix(amazonqFeatureDev): generate uploadId in fe

e1cbe15

fix(amazonqFeatureDev): create a new token to stop and iterate in the…

ae9d16b

… same session

fix(amazonqFeatureDev): removeu unused const

532e4e4

fix(dev): apply fixes based on new eslint rules

d63ceb5

fix(amazonqFeatureDev): use shared context from action to check cance…

f0bbd9f

…llation

fix(amazonqFeatureDev): require isCancellation to localize in the ins…

e604672

…tance and abort the individual call

tverney force-pushed the feature/stop-progress-status branch from 0588d8e to e604672 Compare September 27, 2024 17:42

tverney added 6 commits October 2, 2024 15:58

fix(amazonqFeatureDev): don't share state to prepare code since code …

675c623

…cancellation should be in gen

fix(amazonqFeatureDev): allow follow up options after finally only

2c92f5c

fix(amazonqFeatureDev): disable input placeholder until its done

394c512

fix(amazonqFeatureDev): disable input

0743620

Merge branch 'master' into feature/stop-progress-status

d16c01f

Merge branch 'master' into feature/stop-progress-status

08ceb71

kelvin-klchu and others added 6 commits October 10, 2024 15:49

telemetry(amazonq): add metrics for stop code generation

30735e8

telemetry(amazonq): add metrics for stop code generation

047125b

Merge pull request #1 from kelvin-klchu/stop-code-gen-telemetry-updated

08b85d1

Add stop code gen telemetry

fix(dev): merge conflicts and missing commas

20e5493

fix(dev): update strings

9597f25

chore(dev): include changelog

e9ef770

tverney marked this pull request as ready for review October 16, 2024 14:13

hayemaxi and others added 12 commits October 21, 2024 14:32

feat(amazonqFeatureDev): include stop generation based on token cance…

d70bb9e

…llation

refactor(amazonqFeatureDev): include updated rts model

b99f4db

fix(amazonqFeatureDev): include currentCodeGenerationId to track refe…

5bfde04

…rence for stop code generation

refactor(amazonqFeatureDev): add logic for codeGenerationId

14a620a

fix(amazonqFeatureDev): create a new token to stop and iterate in the…

12e1376

… same session

fix(dev): apply fixes based on new eslint rules

7b7da92

fix(amazonqFeatureDev): use shared context from action to check cance…

3cfaf44

…llation

fix(amazonqFeatureDev): require isCancellation to localize in the ins…

1fd35af

…tance and abort the individual call

fix(amazonqFeatureDev): don't share state to prepare code since code …

597a92d

…cancellation should be in gen

fix(dev): merge conflicts and missing commas

f45a4bb

fix(dev): fix merge conflicts

67d1958

tverney requested a review from a team as a code owner October 21, 2024 19:15

tverney added 3 commits October 21, 2024 15:18

Merge branch 'master' into feature/stop-progress-status

904b4d6

fix(dev): update messaging for total iterations

14593a9

fix(dev): safe check for remainingIterations

3bafa50

tverney requested a review from neilk-aws October 22, 2024 19:38

neilk-aws approved these changes Oct 22, 2024

View reviewed changes

jpinkney-aws reviewed Oct 23, 2024

View reviewed changes

tverney and others added 3 commits October 23, 2024 11:13

fix(dev): apply feedback

e8dddc1

telemetry(amazonq): use ui_click telemetry for stop code generate but…

e6c1e4f

…ton instead

Merge pull request #2 from kelvin-klchu/fix/telemetry

509f835

telemetry(amazonq): use ui_click telemetry for stop code generate button instead

tverney requested a review from jpinkney-aws October 23, 2024 20:34

Merge branch 'master' into feature/stop-progress-status

c7bf2b1

tverney requested a review from hayemaxi October 24, 2024 15:01

hayemaxi approved these changes Oct 24, 2024

View reviewed changes

hayemaxi merged commit 3b20744 into aws:master Oct 24, 2024
21 of 24 checks passed

tverney deleted the feature/stop-progress-status branch October 24, 2024 15:17

dhasani23 reviewed Oct 29, 2024

View reviewed changes

packages/core/src/amazonq/webview/ui/main.ts Show resolved Hide resolved

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dev): Stop code generation action #5675

feat(dev): Stop code generation action #5675

tverney commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 10, 2024

tverney commented Oct 22, 2024

jpinkney-aws Oct 23, 2024

jpinkney-aws Oct 23, 2024

tverney Oct 23, 2024

dogusata Oct 23, 2024

dogusata Oct 23, 2024

tverney Oct 23, 2024

hayemaxi Oct 24, 2024

tverney Oct 24, 2024 •

edited

Loading

feat(dev): Stop code generation action #5675

feat(dev): Stop code generation action #5675

Conversation

tverney commented Sep 26, 2024 • edited Loading

Problem

Solution

github-actions bot commented Sep 26, 2024

github-actions bot commented Oct 10, 2024

tverney commented Oct 22, 2024

jpinkney-aws Oct 23, 2024

Choose a reason for hiding this comment

jpinkney-aws Oct 23, 2024

Choose a reason for hiding this comment

tverney Oct 23, 2024

Choose a reason for hiding this comment

dogusata Oct 23, 2024

Choose a reason for hiding this comment

dogusata Oct 23, 2024

Choose a reason for hiding this comment

tverney Oct 23, 2024

Choose a reason for hiding this comment

hayemaxi Oct 24, 2024

Choose a reason for hiding this comment

tverney Oct 24, 2024 • edited Loading

Choose a reason for hiding this comment

tverney commented Sep 26, 2024 •

edited

Loading

tverney Oct 24, 2024 •

edited

Loading