feat(amazonq): support SQL conversions #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions. |
dhasani23
force-pushed
the
dmsWork
branch
4 times, most recently
from
4db3814 to
a390ea1
Compare
dhasani23
commented
Oct 21, 2024
| @@ -350,6 +350,10 @@ export const updateInlineLockKey = 'CODEWHISPERER_INLINE_UPDATE_LOCK_KEY' | |||
| export const newCustomizationMessage = 'You have access to new Amazon Q customizations.' | |||
|
|
|||
| // Start of QCT Strings | |||
|
|
|||
| // feature flag for SQL transformations | |||
| export const isSQLTransformReady = true | |||
There was a problem hiding this comment.
Will update to false
There was a problem hiding this comment.
For future reference: feature flags should live in dev/config.ts, or as an "experiment" https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#preview-releases-and-experiments
justinmk3
reviewed
Oct 21, 2024
justinmk3
reviewed
Oct 21, 2024
dhasani23
force-pushed
the
dmsWork
branch
3 times, most recently
from
c643ffa to
e12ed81
Compare
dhasani23
commented
Oct 24, 2024
dhasani23
commented
Oct 28, 2024
packages/core/src/amazonqGumby/chat/controller/messenger/messenger.ts
Outdated
Show resolved
Hide resolved
justinmk3
approved these changes
Oct 29, 2024
|
Not ready to be merged yet (as of 10/31 morning) |
added 19 commits
October 31, 2024 09:35
|
|
Update: ready to be merged (feature is behind a feature flag) |
carolabadeer
approved these changes
Nov 1, 2024
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 1, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 5, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 8, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 9, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 9, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
dhasani23
added a commit
to dhasani23/aws-toolkit-vscode-1
that referenced
this pull request
Nov 13, 2024
QCT wants to support converting embedded SQL in Java apps. Allow users to start a transformation for SQL conversions. --- <!--- REMINDER: Ensure that your PR meets the guidelines in CONTRIBUTING.md --> License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
QCT wants to support converting embedded SQL in Java apps.
Solution
Allow users to start a transformation for SQL conversions.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.